search

gurkankaymak / hocon

go implementation of lightbend's HOCON configuration library https://github.com/lightbend/config
MIT License
79 stars 17 forks source link

fix: if the string elements have forbidden characters, add " for them #20

Closed Rory-Z closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #20 (a02c1ab) into master (0131d4e) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   96.69%   96.70%   +0.01%     
==========================================
  Files           3        3              
  Lines         726      729       +3     
==========================================
+ Hits          702      705       +3     
  Misses         17       17              
  Partials        7        7
Impacted Files Coverage Δ
config.go 93.87% <100.00%> (+0.07%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

gurkankaymak commented 2 years ago

can you please explain which case this pr solves? when I checked with sample input {"a":"@!abc"}, current behaviour is the same as the original library

Rory-Z commented 2 years ago

can you please explain which case this pr solves? when I checked with sample input {"a":"@!abc"}, current behaviour is the same as the original library

Hi, @gurkankaymak I will close this PR, and create a new PR, please check https://github.com/gurkankaymak/hocon/pull/22