search

gurki / vivid

A simple-to-use cpp color library
MIT License
167 stars 17 forks source link

Make fails due to old catch.hpp #20

Closed klopyrev closed 1 week ago

klopyrev commented 1 month ago

I get this error running make:

In file included from /usr/include/signal.h:328, from /home/klopyrev/vivid/tests/catch.hpp:6040, from /home/klopyrev/vivid/tests/test_main.cpp:2: /home/klopyrev/vivid/tests/catch.hpp:8749:58: error: call to non-‘constexpr’ function ‘long int sysconf(int)’ 8749 | constexpr static std::size_t sigStackSize = 32768 >= MINSIGSTKSZ ? 32768 : MINSIGSTKSZ; | ^~~ In file included from /usr/include/aarch64-linux-gnu/bits/sigstksz.h:24: /usr/include/unistd.h:640:17: note: ‘long int sysconf(int)’ declared here 640 | extern long int sysconf (int name) THROW; | ^~~ /home/klopyrev/vivid/tests/catch.hpp:8808:45: error: size of array ‘altStackMem’ is not an integral constant-expression 8808 | char FatalConditionHandler::altStackMem[sigStackSize] = {}; | ^~~~

It looks like this problem has already been fixed in catch.hpp: https://github.com/catchorg/Catch2/blob/devel/docs/release-notes.md#2135

But, an old version is used here.

gurki commented 1 month ago

Thanks for raising this! Good point, also a CMake update is overdue. I'll try to make some time for it these weeks and update some of the dependencies.