search

gurkult / gurkbot

Our community bot, used for running the server.
MIT License
18 stars 16 forks source link

Bonk Command #100

Closed ShakyaMajumdar closed 3 years ago

ShakyaMajumdar commented 3 years ago

For #96

v1nam commented 3 years ago

It would be better to move yodobonk.gif to resources/images or some other folder inside resources, so it can be organized when we decide for future image commands

v1nam commented 3 years ago

Same with yodobonk.json, it should go into resources too

ShakyaMajumdar commented 3 years ago

Alright

ShakyaMajumdar commented 3 years ago

Should I put the json directly under resources? or with the gif in resources/images?

v1nam commented 3 years ago

You can put it directly under resources

ShakyaMajumdar commented 3 years ago

done

ShakyaMajumdar commented 3 years ago

@Shivansh-007 what would be the benefit of doing this? Opposed to the Image.save in PIL?

Also, I don't see how I can use that to combine multiple images into 1 gif

ShakyaMajumdar commented 3 years ago

No clue why there were changes in Pipfile.lock, I didn't even touch the file lol

v1nam commented 3 years ago

No clue why there were changes in Pipfile.lock, I didn't even touch the file lol

Pipfile.lock contains info on the pip packages installed, i believe you installed pillow through pipenv install pillow, that does change the Pipfile.lock and the Pipfile

ShakyaMajumdar commented 3 years ago

Oh Am I supposed to use pip install ... instead of pipenv install ... then?

v1nam commented 3 years ago

No

v1nam commented 3 years ago

There is nothing wrong about the Pipfile.lock being changed, it would be a problem if it weren't changed, which will break the docker build

ShakyaMajumdar commented 3 years ago

I see