search

gurkult / gurkbot

Our community bot, used for running the server.
MIT License
18 stars 16 forks source link

LinePaginator #114

Closed Shivansh-007 closed 3 years ago

Shivansh-007 commented 3 years ago

Adds line pagination.

ShakyaMajumdar commented 3 years ago

LGTM 👍

gustavwilliam commented 3 years ago

Lovely to see some reviews coming in! Have you tested this @ShakyaMajumdar @RohanJnr? It’s totally fine if not, but I need to know before merging 😄

ShakyaMajumdar commented 3 years ago

Lovely to see some reviews coming in! Have you tested this @ShakyaMajumdar @RohanJnr? It’s totally fine if not, but I need to know before merging 😄

Yep, tested and works fine for me.

RohanJnr commented 3 years ago

Lovely to see some reviews coming in! Have you tested this @ShakyaMajumdar @RohanJnr? It’s totally fine if not, but I need to know before merging 😄

works fine

gustavwilliam commented 3 years ago

Perfect, thanks. I’ll merge!

gustavwilliam commented 3 years ago

Not much will happen with the reviews. Still, maybe we could update the code to your reviews? @codephile1221 @Shivansh-007 Would you like to create a new PR to update/refine this, or do you have any other ideas?