Closed Shivansh-007 closed 3 years ago
I believe you first implemented this for Sir Lancebot, and then added it here?
@Akarys42 what do you think about licensing? Should we mention that it's ported from Sir Lancebot, or is it fine either way, considering that Jason wrote the command? Other people reviewed it as well, so I'm leaning toward attributing Sir Lancebot, if we want to keep this.
I believe you first implemented this for Sir Lancebot, and then added it here?
@Akarys42 what do you think about licensing? Should we mention that it's ported from Sir Lancebot, or is it fine either way, considering that Jason wrote the command? Other people reviewed it as well, so I'm leaning toward attributing Sir Lancebot, if we want to keep this.
Since the code has been given to Python Discord while contributing and other people put time and effort into it through contributions and discussions, it must be attributed to Python Discord with their license.
On another note, I don't see the point is having 80% of this bot be just Python Discord licensed code. If that's really what we want, why aren't we hosting Sir Lancebot and calling it a day?
I thought it would be fine with Licensing, since @gustavwilliam had added the xkcd command the other day, written by Xithrus.
I believe you first implemented this for Sir Lancebot, and then added it here? @Akarys42 what do you think about licensing? Should we mention that it's ported from Sir Lancebot, or is it fine either way, considering that Jason wrote the command? Other people reviewed it as well, so I'm leaning toward attributing Sir Lancebot, if we want to keep this.
Since the code has been given to Python Discord while contributing and other people put time and effort into it through contributions and discussions, it must be attributed to Python Discord with their license.
On another note, I don't see the point is having 80% of this bot be just Python Discord licensed code. If that's really what we want, why aren't we hosting Sir Lancebot and calling it a day?
Or use the bot as the base, and build upon that with gurkan taste and our commands?
That was a rhetorical question. Either way, I'm not convinced we need this command yet. We can discuss it and get back to you later.
@gustavwilliam Any updates?
Hi @Shivansh-007! I appreciate that you want to contribute and help make Gurkbot better. However, we don't want it to be primarily based on Sir Lancebot. I'll close this issue, and would love to see some more Gurkbot-exclusive commands in the future :smile:
Partially closes #67
This has been implemented with help of
aiohttp
to request and getjson
data of the Wikipedia Article. It then filters the data and stores only the required information namely Title, Snippet and Page ID. This filtered data to the Line Paginator.