Open DudeBro249 opened 3 years ago
@Arnav-2004 do you think it would be worth putting a pip install -U poetry
in the Setup
task?
@Arnav-2004 do you think it would be worth putting a
pip install -U poetry
in theSetup
task?
Yea, probably a good idea.
@Arnav-2004 do you think it would be worth putting a
pip install -U poetry
in theSetup
task?
pip
is not recommended for installing poetry, for reasons detailed on the installation page. Instead, I think you should link the Poetry installation guide. https://python-poetry.org/docs/#installation
how are we going to ignore use generated settings.json file? as vscode tends to generate one/users like to have one for config or is it already handled?
@DudeBro249 I'm fine with this. If you address the feedback from and get an approval from @RohanJnr, I'll be pretty comfortable merging this. Just test it please.
@Arnav-2004 do you think it would be worth putting a
pip install -U poetry
in theSetup
task?
pip
is not recommended for installing poetry, for reasons detailed on the installation page. Instead, I think you should link the Poetry installation guide. https://python-poetry.org/docs/#installation
I'll remove the pip install poetry command in the task and link the poetry installation instructions in the README. (EDIT) Done 👍
how are we going to ignore use generated settings.json file? as vscode tends to generate one/users like to have one for config or is it already handled?
I'll look into this. Could you clarify what you mean by this question though?
@DudeBro249 I'm fine with this. If you address the feedback from and get an approval from @RohanJnr, I'll be pretty comfortable merging this. Just test it please.
I've tested it and it works. I'll make the necessary changes though.
Please don't add this. I love configuring my .vscode/settings.json per project myself, and would appreciate it not being pre-configured.
If we want something like this, we can store them elsewhere, and have a script to copy the files to the correct location, but please do not check files in to the repository where per-user configuration is stored.
Note: This pull request is not trying to make all current and future contributors switch to using VSCode. It just makes it easier for developers already using VSCode to set up, develop, and run gurkbot
.vscode
entry from.gitignore
fileREADME.md
(click to view changes) with development environment setup instructions for VSCode