Closed uncomfyhalomacro closed 3 years ago
I have committed the changes. Waiting for the PR to be merged.
@ReneganRonin one last thing.
Delete the .env
file and replace it with .env-example
so we can have an example file for future people.
After that you'll be good to go.
cool , looks good, just like xith said, change the .env
file to either .env.template
or .env-example
perhaps .DS_Store
could also be added (edit:) to the .gitignore
(new contributors sometimes commit those)
@Vyvy-vi uhm whats a .DS_Store
? also @Xithrius i changed it to .env-template
.
.DS_Store
is a file on macos, that holds info about the folder's properties(how icons are arranged etc..)
perhaps
.DS_Store
could also be added? (new contributors sometimes commit those)
@ReneganRonin what @Vyvy-vi meant by this was to add the .DS_Store
file to the .gitignore
file. There is no need to create another file.
Also, thank you for the refactoring of the name .env
to .env-template
.
Oh, I should have been more specific 😞 Sorry!
it is done. sorry for the confusion. @Xithrius @Vyvy-vi
Everything looks good to me! Nice work.
@fisher60 should we create a new branch called "core"?
Isn't main
analogous to core
?
Imho, we should make a new develop
branch or make a new core
branch and let main
act as the dev-branch 🤔
This will be our final folder structure for our bot project. This PR is related to Issue #10 - Folder structure. Please review this my fellow cucumbers.