gurkult / gurkbot

Our community bot, used for running the server.
MIT License
18 stars 16 forks source link

Folder structure #16

Closed uncomfyhalomacro closed 3 years ago

uncomfyhalomacro commented 3 years ago

This will be our final folder structure for our bot project. This PR is related to Issue #10 - Folder structure. Please review this my fellow cucumbers.

uncomfyhalomacro commented 3 years ago

I have committed the changes. Waiting for the PR to be merged.

Xithrius commented 3 years ago

@ReneganRonin one last thing.

Delete the .env file and replace it with .env-example so we can have an example file for future people.

After that you'll be good to go.

Shivansh-007 commented 3 years ago

cool , looks good, just like xith said, change the .env file to either .env.template or .env-example

Vyvy-vi commented 3 years ago

perhaps .DS_Store could also be added (edit:) to the .gitignore (new contributors sometimes commit those)

uncomfyhalomacro commented 3 years ago

@Vyvy-vi uhm whats a .DS_Store? also @Xithrius i changed it to .env-template.

Vyvy-vi commented 3 years ago

.DS_Store is a file on macos, that holds info about the folder's properties(how icons are arranged etc..)

Xithrius commented 3 years ago

perhaps .DS_Store could also be added? (new contributors sometimes commit those)

@ReneganRonin what @Vyvy-vi meant by this was to add the .DS_Store file to the .gitignore file. There is no need to create another file.

Also, thank you for the refactoring of the name .env to .env-template.

Vyvy-vi commented 3 years ago

Oh, I should have been more specific 😞 Sorry!

uncomfyhalomacro commented 3 years ago

it is done. sorry for the confusion. @Xithrius @Vyvy-vi

Xithrius commented 3 years ago

Everything looks good to me! Nice work.

uncomfyhalomacro commented 3 years ago

@fisher60 should we create a new branch called "core"?

Vyvy-vi commented 3 years ago

Isn't main analogous to core? Imho, we should make a new develop branch or make a new core branch and let main act as the dev-branch 🤔