search

gurkult / gurkbot

Our community bot, used for running the server.
MIT License
18 stars 16 forks source link

Automatically give Gurkan role on name change #32

Closed RandomDev26 closed 3 years ago

RandomDev26 commented 3 years ago

This feature would have the bot check a member's name every time it changes and if a variant of gurkan is in the name, it would give the gurkan role, else if it is not, it would remove the role. This would be done using the "on_member_update" function of discord.py.

Shivansh-007 commented 3 years ago

What if a persons's discord username is gurkan? And what if someone tries spamming, how about using tasks? We could run it every 1 hour or 30 minutes?

RandomDev26 commented 3 years ago

What if a persons's discord username is gurkan?

I'll also have it check on join

And what if someone tries spamming, how about using tasks? We could run it every 1 hour or 30 minutes?

Yes, I agree

gustavwilliam commented 3 years ago

And what if someone tries spamming, how about using tasks? We could run it every 1 hour or 30 minutes? Only checking for this at certain time intervals doesn't sound too good UX-wise. I'd rather receive some minor spam from one odd person. They probably won't even consider this a feature to spam.

However, if we want to be on the safe side, I'm not against implementing some sort of warning for this. Let's say that a person changed their name 15 times in a minute. Then, I wouldn't mind potting that person on a cool down and saying "Hey, you've changed your name X times in Y minutes. Cool down," also possibly pinging the Steering Council.

We could also use a totally different model, where users only change their nicks through a !nick command. This would allow for flexibility with cool downs and similar, but I'm not a huge fan of restricting the user in this way. The UX of it isn't too nice imo.

At the end of the day, I don't think we'll be having an issue with this, so I wouldn't mind just ignoring it. But if we do want a warning of sorts, it would preferably be in a way similar to what I proposed above.

RandomDev26 commented 3 years ago

I agree, I don't think anyone will think of spamming this feature. So would you like for me to add in a warning or not?

gustavwilliam commented 3 years ago

Not for now.

Arnav-2004 commented 3 years ago

You need to fix one thing if not already done : It adds Gurkans role to the bots which have gurkan in their name like this one image

RandomDev26 commented 3 years ago

Added that in rn