search

gurkult / gurkbot

Our community bot, used for running the server.
MIT License
18 stars 16 forks source link

Feature/error handler #34

Closed Shivansh-007 closed 3 years ago

Shivansh-007 commented 3 years ago

Closes #29

Xithrius commented 3 years ago

@Shivansh-007 Please make the commit messages more descriptive. "Update " doesn't tell us anything.

Xithrius commented 3 years ago

@Shivansh-007 This was probably a mistake and I don't blame you for doing it, but please remember to change these types of commits in the future.

Examples being 72a37527d7d0c71b232b152822485d779e3bb568 and 04379b8's commit messages.

Shivansh-007 commented 3 years ago

Alright No Problem!

uncomfyhalomacro commented 3 years ago

@Shivansh-007 u can always use git commit --amend to redefine your commit messages. So Xithy and Fishy will find it easier to review your code.

vivekashok1221 commented 3 years ago

@Shivansh-007 Note: The return statement in the handling of each error will need to be removed, if you decide to take my suggestions into consideration.

gustavwilliam commented 3 years ago

Do we have any progress on this? It's a high priority task that we should get merged quite soon.

Shivansh-007 commented 3 years ago

Waiting for @fisher60 and @Xithrius to do the final review!

Xithrius commented 3 years ago

@Shivansh-007 to what extent have you tested this error catcher?

vivax3794 commented 3 years ago

I have redirected this pr to main, following issue #61

Xithrius commented 3 years ago

@Shivansh-007 Please resolve the conflicts before continuing.

Shivansh-007 commented 3 years ago

Mentioned the changes @gustavwilliam