search

gurkult / gurkbot

Our community bot, used for running the server.
MIT License
18 stars 16 forks source link

`isgurkan` command works for any input. #70

Closed SuperMaZingCoder closed 3 years ago

SuperMaZingCoder commented 3 years ago

The !isgurkan command is currently accepting any input, regardless of whether it is an actual user or not. Here is an example:

image

I think we should add some checks to ensure that the input is a mention or user ID. What do you all think?

Inheritanc-e commented 3 years ago

We should just specify the parameter to be discord.Member, because

  1. Not everyone has developer mode turned on.
  2. People don't when they are pinged for no reason.
gustavwilliam commented 3 years ago

I personally don't mind checking strings. For example, something like this should be valid imo:

Screenshot 2021-01-10 at 18 12 36
gustavwilliam commented 3 years ago

I'm closing this, unless we have something more to add.