search

gurkult / gurkbot

Our community bot, used for running the server.
MIT License
18 stars 16 forks source link

subscribe and unsubscribe commands #71

Closed Arnav-2004 closed 3 years ago

Arnav-2004 commented 3 years ago

all the suggestions and changes from the old/closed PR have been resolved

Arnav-2004 commented 3 years ago

Had to close the earlier pr because I deleted the fork. This will close issue#31

RohanJnr commented 3 years ago

@Arnav-2004 are you planning on continuing this PR?

Arnav-2004 commented 3 years ago

@Arnav-2004 are you planning on continuing this PR?

Yes, after 18th March I will be working on it. Because of school exams I am not able to work on it.

RohanJnr commented 3 years ago

Also, I see a problem with the function names and doc strings, just for an example: function: subscribe_group_helper This name does not make anything clear, a better name would be _subscribe and the doc string could be Subscribe for announcements and polls. the current docstring Helper function for unsubscribe_group. Sends embed for role unsubscription. does not tell the actual functionality of the function, the function is also removing roles which is the main thing not mentioned in the doc string

gustavwilliam commented 3 years ago

Let's do it.