[XML] Fix parsing of testrail_case_field with empty xml but value present - Githubissues

gurock / trcli

TR CLI (trcli) is a command line tool for interacting with TestRail.

Mozilla Public License 2.0

48 stars 39 forks source link

[XML] Fix parsing of testrail_case_field with empty xml but value present #216

Closed GermanDZ closed 3 months ago

GermanDZ commented 3 months ago

Issue being resolved: https://github.com/gurock/trcli/issues/217

Solution description

When the property named testrail_case_field has a text node but it's empty just use the value.

Changes

Added a new test case
Added a new check to decide to use the XML node's text or the value.

Potential impacts

If some XML is providing values on both text and value, the text will be used first.

Steps to test

Already added to fixtures.

Failing tests before fix: https://github.com/gurock/trcli/actions/runs/8205303102

PR Tasks

[x] PR reference added to issue
[ ] README updated
[x] Unit tests added/updated

bitcoder commented 3 months ago

Thank you for the PR, merging