gurrgur / er-patcher

Elden Ring enhancement patches (ultrawide support, custom frame rate limits and more) seamlessly integrated with steam.
MIT License
311 stars 25 forks source link

Worse performance with the Ultrawide fix option #14

Closed krasmazov483 closed 2 years ago

krasmazov483 commented 2 years ago

Hello there!

From what I saw on reddit when Elden Ring launched was that the game had proper ultrawide built-in but the game overlays it with black bars. There are posts about it like this one or this one for example.

That would mean that the game is already rendering the extra space but simply refusing to show it to the player. If that is true, then removing the black bars should not decrease performance, but from my own testing this is not the case as I see performance degradation from 5-10 FPS when removing the black bars. I couldn't find other people reporting the same issue, so I decided to test it.

Screenshots This was taken on the Windmills area, and there is a **5 FPS** decrease overall: ![Screenshot_20220323_202459](https://user-images.githubusercontent.com/9277125/159818103-4f91081c-8032-4b3a-b460-2c08dad9acb4.png) ![Screenshot_20220323_202300](https://user-images.githubusercontent.com/9277125/159818128-b5aec7ff-cf24-4502-8c30-295a42f5ec05.png)

This also seems to happen on Liurnia of the Lakes, where I get 50-60 FPS, mostly 55, without the patcher and 40-50 FPS, mostly 45, with the patcher. This wouldn't be much of a problem in itself but I can really feel the difference, probably because the lowest Freesync range of my monitor is 45 Hz and the game gets choppy around that framerate.

I did the testing with only the ultrawide option, without it but with the patcher to start offline, without the patcher completely and with only the following options: -uvasf, the results were consistent throughout. Unlocking the framerate also made no difference.

I can't test with other patchers like Flawless Widscreen since I don't have a windows installation on this computer, so, my question here is: is this is supposed to happen? And if not, can it be fixed in this patcher somehow? Or is it an issue with the game itself?

gurrgur commented 2 years ago

Based on the testing I did, the game runs with the exact same performance with both FWS and er-patcher (on windows ofc). It makes sense since the modifications they perform are basically identical. When using FWS to toggle black bars at runtime I noticed a slight performance impact so I guess it might be an issue with the game.

Can you reproduce the framerate difference when comparing ./er-patcher -uvasf -- %command% to ./er-patcher -vasf -- %command%? Also please double check that in both cases the same resolution is used. I had the game launch with a 16:9 resolution when starting without mods before. Just want to make sure that our launching mechanism is not causing it.

Edit: Just reread and it seems like I missed that you already tested what I'm suggesting. I conclude that this is most likely an issue with the game.

krasmazov483 commented 2 years ago

Yeah I did test it out before but I decided to do it again since Proton Experimental got an update, but the results are the same, ./er-patcher -uvasf -- %command% gives performance penalty and either no er-patcher or ./er-patcher -vasf -- %command% gives me base performance.

I don't have access to a newer Mesa release so I can't be sure if any improvements there would change anything. I'll try on another distro with newer Mesa and report back, close this issue if you see fit tho.

gurrgur commented 2 years ago

Mesa 22 might help. For me it gave a boost of ~15% over 21.3.7 with an RX570. With 21.3.7 the gpu load shown in mangohud was around 85-90% whereas with mesa 22 it's basically a flat 100%.

Anyway, since this doesn't seem to be an issue with our patch, I'll close this issue.

krasmazov483 commented 2 years ago

Just as a final update in case anyone stumbles upon this issue:

Instead of trying on another distro I locally built mesa 22.0.0 and tried it on Elden Ring. The game fails to run because EAC needs 32-bit drivers (pointing to your old 32-bit mesa alongside the new 64-bit mesa works fine), but using er-patcher lets the game open and the difference is stark. I now manage to get 60-75 FPS on Liurnia alone from my small testing.

So yeah if anyone happens to have performance issues on Ultrawide in Elden Ring on an AMD GPU, Mesa 22.0.0 and up will have you covered.