gurrgur / er-patcher

Elden Ring enhancement patches (ultrawide support, custom frame rate limits and more) seamlessly integrated with steam.
MIT License
306 stars 25 forks source link

Flag to allow the game to run with EAC #25

Closed joao-pedro-braz closed 2 years ago

joao-pedro-braz commented 2 years ago

Hello All,

This Feature adds a flag to the script that allow the game to start with EAC enabled, by making Steam execute the "start_protected_game.exe" instead of the "eldenring.exe".

At the time of writing, I've been playing the game online with all fixes active and with EAC enabled for the better part of a week. I'm yet to encounter any problems with EAC/Online Playing due to the hex edits, but good-judgment must be made by the player, as to whether use or not this feature.

As evidence that it does in fact work, here is a screenshot of me playing the game online with all fixes active: image

Best Regards, João Pedro Braz

gurrgur commented 2 years ago

Hello, thanks for this pull request! Did you intentionally not add documentation to the readme or is this intended to be a "hidden" feature? To know this feature exists currently one would have to effectively read the source code.

I think if we add this feature it would be best to document it in the readme and put a bold warning in the flag description.

joao-pedro-braz commented 2 years ago

Hello!

Yeah, I forgot to do that... 🙂 I'll fix it in a gist, thanks for pointing it out!

Best Regards, João Pedro Braz

joao-pedro-braz commented 2 years ago

Hello!

Just committed an update to the README, adding the flag to the Features table.

Best Regards, João Pedro Braz

joao-pedro-braz commented 2 years ago

Hello!

I updated the README to make it clearer that it's possible to run the game with EAC enabled. Don't mind the reverted commit, had a brain fart.

Best Regards, João Pedro Braz

gurrgur commented 2 years ago

Thanks for the update! It looks fine now :)