gurrgur / er-patcher

Elden Ring enhancement patches (ultrawide support, custom frame rate limits and more) seamlessly integrated with steam.
MIT License
311 stars 25 forks source link

Update Ultrawide fix to version 1.04 #26

Closed joao-pedro-braz closed 2 years ago

joao-pedro-braz commented 2 years ago

Hello All,

This Feature updates the Ultrawide fix so it works with the 1.04 version of Elden Ring, released yesterday (20th of April 2022).

Evidence of the game running in a 21:9 resolution with the patch 1.04 applied: image

Patch version (bottom right corner) image

Best Regards, João Pedro Braz

gurrgur commented 2 years ago

Thanks for this! I'd prefer to use a pattern with wildcards to make it more robust w.r.t. possible future game updates. Though it's better to have a working patch than a non-existent perfect one ;)

Unfortunately update 1.04 has made the game crash at launch for me so I cannot test this currently.. But the path looks fine overall so I'll merge :)

joao-pedro-braz commented 2 years ago

Hello!

Yeah, that's probably a good idea, I'll work on it. Currently there's 4 patches without the wildcard, I'll change them all in another PR, as to maintain consistency between the fixes.

Best Regards, João Pedro Braz

gurrgur commented 2 years ago

I think it's not necessary to be so perfectionist about it at the moment. As long as they work they are fine and when (if) they break we can analyze which bytes have changed and add wildcards accordingly :)

mikeyd85 commented 2 years ago

Thanks for this! I'd prefer to use a pattern with wildcards to make it more robust w.r.t. possible future game updates. Though it's better to have a working patch than a non-existent perfect one ;)

Unfortunately update 1.04 has made the game crash at launch for me so I cannot test this currently.. But the path looks fine overall so I'll merge :)

I've tested this on my machine, and can confirm that it works. Pop OS 22.04 using Proton Experimental.

joao-pedro-braz commented 2 years ago

Hello,

That's great @mikeyd85 thanks for testing it out! @gurrgur alright, let's keep an eye on it.

Best Regards, João Pedro Braz