gurrgur / er-patcher

Elden Ring enhancement patches (ultrawide support, custom frame rate limits and more) seamlessly integrated with steam.
MIT License
306 stars 25 forks source link

feature: improved launch #4

Closed DinCahill closed 2 years ago

DinCahill commented 2 years ago

Hi, two little features:

If -- is not provided on the command line, default to eldenring.exe. This allows you to:

If the script is in the same directory as eldenring.exe, assume that is the game directory. Otherwise, assume we are already in the game directory. This allows you to:

Please let me know what you think 🙂 .

gurrgur commented 2 years ago

Hey,

Run the script from the command line with just ./er-patcher -uvca.

couldn't you just use .\er-patcher ARGS -- .\eldenring.exe ? The last argument could be any file in the game directory. Also, this feature would not work cross platform since running the exe directly wouldn't work on linux.

Rename the script to .py or .pyw, and launch it by double clicking it. It won't apply any patches, but if you could load options from an ini file, it would work. You can also make a shortcut, and add the arguments that way.

Definitely don't want to do config with an ini file. Also, if you create a shortcut anyway, the above should work fine. If you really want to use er-patcher as a launcher by renaming it to er-patcher.py you could also just hardcode the patch config in the script.

Run the script while you're outside the game directory, as long as the script is in the game directory

The main usecase I'm aiming to support is running the game directly from steam. In that case it's fair to assume the script will be called from within game dir.

If you really wanted to try launching the game without steam from an arbitrary folder, on Linux you could just env --chdir=/wherever/the/game/is/located ./er-patcher ARGS -- wine ./eldenring.exe. I suppose powershell would have a similar command / option?

DinCahill commented 2 years ago

Thanks for the feedback. Closing this PR as unnecessary.