Add "-l" for "--disable-rune-loss", fix typos and improve readme and er-patcher

gurrgur / er-patcher

Elden Ring enhancement patches (ultrawide support, custom frame rate limits and more) seamlessly integrated with steam.

MIT License

301 stars 25 forks source link

Closed Kazevic closed 1 year ago

gurrgur commented 1 year ago

Hi, thanks for this MR. I like the idea of using -l for the rune loss option but other than that I do have some issues with the MR:

The changes are mostly cosmetic and don't really solve any issue.
I get that streamlining the mish-mash of "disable" and "remove" is a cosmetic improvement but IMO that doesn't justify the introduction of breaking changes.
Currently, the options are sorted by inclusion in --all, why should this be changed?

Kazevic commented 1 year ago

The "fix" part was referring to the typos; I wanted to put a title as short as possible. Also, even if they are mostly cosmetic, I think that it could save some time to people in practice, not to mention that they lower the file sizes.
What exactly became broken after the changes? I could try to fix it.
I sorted them by alphabetical order, but the order of inclusion was changed too, so it should not cause issues.