search

gurrgur / er-patcher

Elden Ring enhancement patches (ultrawide support, custom frame rate limits and more) seamlessly integrated with steam.
MIT License
301 stars 25 forks source link

Not working on Win11 + 1.10 game version #55

Closed NostromoUS closed 8 months ago

NostromoUS commented 9 months ago

Hopefully someone sees this!

I first tried with python 3.12 directly from their website and nothing happened, uninstalled then tried with the Store version and now it does open python console, then closes it and the game never starts. I tried everything I thought of, including "unblocking" the er-patcher file as Windows for some reason "blocks it" as it's probably not signed / recognized.

Any ideas? Anything I can edit in the file to make it work? I can see the temp folder is created and populated btw. If I try to run the eldenring.exe in there it just says a ton of dlls arent installed such as oo2core etc

I've tried:

python er-patcher --rate 120 --disable-vigniette --disable-ca --skip-intro --remove-60hz-fullscreen --disable-rune-loss -- %command%

and even simpler

python er-patcher --rate 120 --all --disable-rune-loss -- %command%

Thanks!

gurrgur commented 9 months ago

Has it ever worked for you on a previous version of the game or windows? 1.10 should be working fine so I guess its something with your setup.

Since the console window opens and the temp folder is created, the patcher script runs as intended, so no "blocking" by windows.

You can try python er-patcher -- %command% to see whether this is caused by any of the patches. Other than that I dont know what the problem could be. Dont have windows 11 either, so I cant test it on that.

mtnorthcott commented 9 months ago

To fix this on Windows 11, you can change L137 to

(game_dir_patched / f).hardlink_to(f)
gurrgur commented 9 months ago

Oh, ok. It seems then the core issue at play is that python 3.12 finally removed the link_to method.

gurrgur commented 9 months ago

@NostromoUS Can you please test this change and report back whether it solves your issue?

You can get the updated version here: https://github.com/gurrgur/er-patcher/tree/python-3-12-compat

Also thanks @mtnorthcott for the fix.