gurrgur / er-patcher

Elden Ring enhancement patches (ultrawide support, custom frame rate limits and more) seamlessly integrated with steam.
MIT License
301 stars 25 forks source link

Game fails to open with Seamless Coop #61

Closed R4ng3x closed 1 month ago

R4ng3x commented 6 months ago

Opening the game with the normal launcher works perfectly, but opening it with Seamless Co-op opens the cmd and the game pretends to open but closes instantly.

I am playing on Windows 11 with the game on the latest version and Seamless Co-op on v1.5.1.

Juppstein commented 1 month ago

Same here with er-patcher and the latest seamless-coop 1.7.6 running on Linux Steam/Proton Experimental

metinc commented 1 month ago

I can confirm this bug. As a temporary workaround you can open the file er-patcher and remove the very last line: rmtree(game_dir_patched)

I will have a look at this and might open a PR if I find a solution.

For debugging I'll leave the error message here:

PS C:\Program Files (x86)\Steam\steamapps\common\ELDEN RING\Game> python er-patcher --all --executable .\ersc_launcher.exe -- .\eldenring.exe
Traceback (most recent call last):
  File "C:\Program Files (x86)\Steam\steamapps\common\ELDEN RING\Game\er-patcher", line 152, in <module>
    rmtree(game_dir_patched)
  File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.11_3.11.2544.0_x64__qbz5n2kfra8p0\Lib\shutil.py", line 787, in rmtree
    return _rmtree_unsafe(path, onerror)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.11_3.11.2544.0_x64__qbz5n2kfra8p0\Lib\shutil.py", line 634, in _rmtree_unsafe
    onerror(os.unlink, fullname, sys.exc_info())
  File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.11_3.11.2544.0_x64__qbz5n2kfra8p0\Lib\shutil.py", line 632, in _rmtree_unsafe
    os.unlink(fullname)
PermissionError: [WinError 5] Access is denied: 'er-patcher-tmp\\eldenring.exe'