search

gurrhack / NetHack-Android

Android port of NetHack
128 stars 23 forks source link

Update to NetHack 3.6.7 #74

Closed mmatuska closed 2 months ago

mmatuska commented 3 months ago

This PR merges the "NetHack-3.6.7_Released" tag and adds a GitHub actions build. The GitHub actions build uploads the release apk as an artifact that can be downloaded from the "Actions" menu and tested on Android devices and emulators (and also used for release building in the future).

gurrhack commented 3 months ago

👍 Will review it later this week

mmatuska commented 3 months ago

👍 Will review it later this week

I think we well need more fixing here. It does not build with any later than ubuntu 20.04 (using 22.04 action runner you end up in compilation errors). And on 20.04 actions complete the build but don't install after signing with developer key.

gurrhack commented 3 months ago

Perhaps you can remove the workflow for now and I'll approve and merge the rest.

gurrhack commented 3 months ago

I was able to make it build locally using Ubuntu 23.04 with Gradle 6.7.1 and Java 11.

~With Gradle 7.6.x you'll also have to update com.android.tools.build to 7.4.2 and run Java 19. It still doesn't build because of some dependency error, so I gave up on that. It might be because the ForkFront library is built with an older version.~

Forget that last part. It builds with Gradle 7.6.x and the old android tools version too. What kind of error did you get on Ubuntu 22.04?

mmatuska commented 3 months ago

So I have reduced this PR to just a 3.6.7 update. But it would still be nice to have the automated build, maybe another PR.