gursesl / cherrypie

Cherry pie making recipes
0 stars 1 forks source link

An in-range update of react-router is breaking the build 🚨 #151

Open greenkeeper[bot] opened 6 years ago

greenkeeper[bot] commented 6 years ago

Version 4.3.0 of react-router was just published.

Branch Build failing 🚨
Dependency react-router
Current Version 4.2.0
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

react-router is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details - ❌ **continuous-integration/travis-ci/push** The Travis CI build failed [Details](https://travis-ci.org/gursesl/cherrypie/builds/388829137?utm_source=github_status&utm_medium=notification)

Release Notes v4.3.0

The major new things of this release are Redirect with params (see #5209) and the new generatePath API. We also cleaned up the code with Prettier, so browsing through it should be more enjoyable.

One other thing to mention, while I have your attention, is the deprecation of react-router-redux. It's no longer maintained and has a number of fundamental problems (particularly around time travel). Integrating Redux and the DOM History API is challenging because they don't maintain the same semantics and the resulting integration is error prone. Getting to the router context will be easier in future versions of React Router, so the main motivations for needing it will be going away. So, while I would advise against trying to integrate the two, for those that still want this functionality can turn to libraries like @supasate's connected-react-router.

Changes

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 6 years ago

After pinning to 4.2.0 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

greenkeeper[bot] commented 6 years ago

Version 4.3.1 just got published.

Your tests are still failing with this version. Compare the changes 🚨

Release Notes v4.3.1

Just a patch to fix an accidental move of warning from a normal dependency to a devDependency, which was causing issues with installation.