User/cameron jung/#209 - Githubissues

gurtejboparai / bookwyrm

A project for Software Engineering II WInter 2022

2 stars 3 forks source link

User/cameron jung/#209 #227

Closed CameronJung closed 2 years ago

CameronJung commented 2 years ago

Changed implementation to use front end storage

The new implementation has 2 accessors same as the original one for the entire genre list and another that won't include "Overall"
All new genre based implementation should use these methods
changed all files (to the best of my knowledge) using a hardcoded genre list to use these storage accessors through computed variables
this closes #209

CameronJung commented 2 years ago

It looks like our tests don't like the fact that genres is computed, I'll have to change the computed variables back into regular vue variables that are initialized by a hook. I started doing something else though. Hopefully I can get to this later this afternoon.

LukeBMorrow commented 2 years ago

If I'm remembering correctly, you have to setup the store getters inside the test to get it to work as expected.

CameronJung commented 2 years ago

alright I'll try that thanks

CameronJung commented 2 years ago

Yup that works, although it doesn't seem like it works if the fake store on the tests uses data() instead of state().