search

gurucomputing / headscale-ui

A web frontend for the headscale Tailscale-compatible coordination server
BSD 3-Clause "New" or "Revised" License
1.59k stars 113 forks source link

Rename Machine into Node #115

Closed juanfont closed 4 months ago

juanfont commented 10 months ago

Hi there,

Headscale maintainer here :)

FYI, we are renaming Machine into Node - to better fit the internal naming of Tailscale. This might impact this project.

You can track the status of the change here https://github.com/juanfont/headscale/pull/1553

routerino commented 10 months ago

Thanks for the heads up, I don't think that affects the UI as it's always been referring to machines as devices :).

Unless it affects the API at least. Any changes to the API will meet swift and decisive ~swearing~ updates to the UI.

juanfont commented 10 months ago

It will affect the API, unfortunately.

Any mention of machine is changed into node.

On Sat, Sep 23, 2023, 01:33 routerino @.***> wrote:

Thanks for the heads up, I don't think that affects the UI as it's always been referring to machines as devices :).

Unless it affects the API at least. Any changes to the API will meet swift and decisive swearing updates to the UI.

— Reply to this email directly, view it on GitHub https://github.com/gurucomputing/headscale-ui/issues/115#issuecomment-1732126490, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABMGQ3QYJVX543EYE5RMELX3YN5FANCNFSM6AAAAAA5C2A4VA . You are receiving this because you authored the thread.Message ID: @.***>

sponnusa commented 9 months ago

Thanks @juanfont.

I've updated the API endpoints and it is working fine. Once the changes are verified, the pull request should be merged into the master.

98h398hrpohpoai commented 7 months ago

Noting for anyone that might encounter this that it's still broken in the current release file from January. The api can be manually corrected by replacing "machine" with "node" in ./web/_app/immutable/chunks/apiFunctions-60f89b05.js

jspin991513 commented 7 months ago

Unfortunately that's not the only file. Performing a grep turned up the following: ./_app/immutable/chunks/apiFunctions-60f89b05.js ./_app/immutable/components/pages/devices.html/_page.svelte-ad198750.js

It appears that there is some old logic for the /api/v1/routes path that needs some work. I'm still looking into it....

jspin991513 commented 7 months ago

Ok, it appears that /api/v1/node/1/routes no longer works. Is this a bug?

routerino commented 7 months ago

If you're trying to modify post-compiled svelte code you're going to have a bad time.

If you want to test headscale ui with the alpha headscale release, you will need to check out this branch and compile a release. Once the headscale release is in beta or RC I will start compiling beta releases.

jspin991513 commented 7 months ago

If you're trying to modify post-compiled svelte code you're going to have a bad time.

If you want to test headscale ui with the alpha headscale release, you will need to check out this branch and compile a release. Once the headscale release is in beta or RC I will start compiling beta releases.

Thanks @routerino. It helps to do things right from the beginning.

Hi-Timofey commented 5 months ago

still got requests to /api/v1/machine from UI using latest docker image of headscale-ui. any updates on issue?

routerino commented 5 months ago

still got requests to /api/v1/machine from UI using latest docker image of headscale-ui. any updates on issue?

Believe it or not, I'm not in the habit of creating a release that would break the production version of headscale to accommodate the alpha version.

All the current pull requests do not dynamically detect or account for both versions. I'll accept a pull request that does so, or make up one myself when it hits beta.

Hi-Timofey commented 5 months ago

still got requests to /api/v1/machine from UI using latest docker image of headscale-ui. any updates on issue?

Believe it or not, I'm not in the habit of creating a release that would break the production version of headscale to accommodate the alpha version.

All the current pull requests do not dynamically detect or account for both versions. I'll accept a pull request that does so, or make up one myself when it hits beta.

Had no idea if this beta or alpha, sorry. Docker hub just show version 23, but not the "alpha" mark. Will be w8ing for update.