search

gurumitts / pylutron-caseta

Apache License 2.0
153 stars 98 forks source link

Fix area tree discovery #129

Closed danaues closed 1 year ago

danaues commented 1 year ago

Currently, the area discovery ignores any area that has the field IsLeaf: False

Unfortunately, this leads to a broken area tree for RA3/HWQSX if the area's don't contain any control stations or devices.

In the example below, both "tree 1" and "tree 2" areas are reported as having "None" parent, because the isLeaf field is False as a consequence of not containing any devices/control stations. "tree 3" correctly reports it's parent as "tree 2"

image

This update ignores the IsLeaf field, and discovers all areas defined on the bridge/processor, maintaining the correct parent/child relationship.

mdonoughe commented 1 year ago

Can you explain this change in the changelog?

danaues commented 1 year ago

Yes, no problem

danaues commented 1 year ago

Thanks!

danaues commented 1 year ago

If you are ok release this as 0.17.1, I'll PR the bump to HA.

mdonoughe commented 1 year ago

https://pypi.org/project/pylutron-caseta/0.17.1/

danaues commented 1 year ago

Thanks!