search

gurumukhi / YouTubeAdBlocker

Cross browser addon to removes all annoying Ads and Banners from YouTube
4 stars 0 forks source link

Unfortunately, I still can see several ad videos #3

Open Decopi opened 3 years ago

Decopi commented 3 years ago

Hi @gurumukhi !

Firstly, thanks for your YouTubeAdBlocker.

Unfortunately, I still have ads before the main targeted video. I'm not an expert, so I can't technically describe you the issue. But in my layman words I would say: Before some videos, I can see one ad video (without the skippable button), and sometimes I can see two or more different types of ad videos. After several seconds these ads video disappear, and the main video appears.

Also, if I open the browser console (I'm using latest Firefox Nightly: shift + ctrl + I => network), your add-on blocks nothing.

I'll be more than happy to help you to solve this issue. As I said, I'm not an expert, I don't know what/how to send you logs etc, but (please) if you guide me, I can send/report or test whatever you want me to do. Count on me!

Thanks in advance!

gurumukhi commented 3 years ago

Thanks for reaching out @Decopi, I fixed one issue yesterday as tracked at https://github.com/gurumukhi/YouTubeAdBlocker/issues/2.

Can you please get the latest version of the addon from https://addons.mozilla.org/en-US/firefox/addon/ad-free-youtube/ & try again to see if you still see the ad? Also, to see the addon logs you can follow these steps:

  1. Type "about:addons" in url and press enter (or you can just press ctrl+shft+ a)
  2. Select "AdFree YouTube" addon.
  3. Go to "Preferences" section & turn debug mode on by pressing On radio button and click save.
  4. Then open YouTube in new tab & check logs (by selecting "inspect element" from right click menu & going to "console section" of developer tools.

Thanks, Ram

Decopi commented 3 years ago

Hi Ram @gurumukhi , thanks for your replay.

As you can see, I posted my issue yesterday, so I already was using your latest YouTubeAdBlocker (AdFree YoutTbe 1.3.0). And as I wrote yesterday, unfortunately I'm seeing around 1 to 3 ad videos before the main video.

As you guided me, I saved the "debug mode" at preferences, opened the Toggle Tools => Console, and I exported the visible messages into a file. Below I attach you 3 files containing 3 random youtube videos, where I saw 1 to 3 ad videos before the main video. I hope this info will be useful to you. If I did something wrong or if you need something else, please keep counting on me!... it'll be a pleasure to help you to catch these pesky ad videos.

I ran all my tests on latest Nightly, untouched, default settings, having installed only your add-on.

Thanks!

console-export-2020-10-12_13-47-14.txt console-export-2020-10-12_13-38-58.txt console-export-2020-10-12_13-51-5.txt

gurumukhi commented 3 years ago

In the console logs I can see the addon is working fine. Which means, if there is any ad with Skip button being played it will automatically skip that ad. I also tested it on my browser & working fine for me. Try try deleting the addon & re-installing, this is to ensure no obsolete version of the addon is active on the browser. Hope this will fix the issue.

Thanks :)

Decopi commented 3 years ago

Hi @gurumukhi ! Thanks once again for your replay, time and attention.

As I explained in my previous message, all my tests are done on latest Nightly, clean install, untouched, default settings, and having installed only your add-on (latest version). But I accepted your suggestion (it doesn't hurt lol), and I deleted my Nightly, making a brand new clean install, of course also installing your add-on. And unfortunately, I still can see ad videos before the main video. By the way, days ago I did same test in different devices, and also in different IPs (sadly, all tests showed ad videos).

With regards to the console logs I sent you, I can't interpret them (I don't have knowledge to understand them), I just sent them to you hoping you'll find the problem. But if you're saying that my console logs are showing your add-on working fine... then "Houston, we have a problem" lol... because regardless the console logs, I can see 1 to 3 ad videos before the main video.

However and if I well understand you, it seems that my console logs showed only the "skippable ad videos". But most of the ad videos that are appearing are not "skippable ad videos" (sorry, I don't know how to classify them). They're videos with normal play button, and user has two options: a) Click play button, wait "x" seconds, skippable button appears, or b) Do not click play button, wait "x" seconds, ad video disappears. So, from my ignorance, perhaps my console logs are showing your add-on working fine, just because your add-on doesn't block the kind of ad videos I'm seeing (your add-on only blocks skippable ad videos).

By the way, this is not the first time I saw this issue. Other add-ons claim to block ads, they indeed partially block ads (but they don't block all ads). At your AMO' page you wrote: "Removes all annoying Ads and Banners from YouTube."... so I was excited, hoping that your add-on will be the first one to really block "all kind of ads".

@gurumukhi , I can confirm you: 1) I'm testing everything always using clean install of latest versions of Nightly + Your add-on. 2) Unfortunately, before main video, 1 to 3 ad videos are appearing, not all of them have skippable button.

You always will count with my help! I can test and send to you whatever you need. Please count on me if you're willing to solve this issue, blocking all kind of YT ad videos. But if you prefer to close this issue, please feel free to do that.

Thanks a lot!

gurumukhi commented 3 years ago

Looks like after recent makeover of YouTube site it is becoming difficult to block few types of ads. I have changed the description of the addon listing (https://addons.mozilla.org/en-US/firefox/addon/ad-free-youtube/) to better reflect the current status. I have added labels seeking marking it open for new developers to try adding more functionalities here, I will keep the issue open for few days to see if we can further improve the functionalities.

Thanks, Ram

Decopi commented 3 years ago

Hi Ram,

If by chance this helps you, the only way I can 100% block all these YT' non-skippable ads is by using a RegExps-blocker with the following rule: [\=\&_-.\/\?\s\d]adunit[\=\&_-.\/\?\s\d] I'm not an expert, I just found this RegExps solution in the web, I copied/pasted, and worked for me... it nukes YT' ads, zero YT' non-skippable ads. I hope this solution can be included inside your "AdFree YouTube" add-on. If that can be done, it'll be great, because then your add-on will become the perfect YT' blocker for me, I'm not going to need additional blockers, and this will improve my browser performance.

I also found in the web a larger list of YT CSS elements to block, so if this helps you, I attach it here: https://pastebin.com/fQFMi9GX.

Thank you again @gurumukhi !

PS: By the way, at your AMO' page, in add-on main text description, it's possible to read: "* This add-on automatically hides all annoying ad banners"