search

gurumukhi / youtube-screenshot

Cross browser addon for youtube video screenshots
https://addons.mozilla.org/en-US/firefox/addon/youtube-screenshot-button/
Mozilla Public License 2.0
41 stars 8 forks source link

Add screenshot format to addon settings #18

Closed joggee-fr closed 2 years ago

joggee-fr commented 2 years ago

It allows to choose between default JPEG or added option PNG. It will address issue #16. Other formats can be added to options, like WebP for example.

joggee-fr commented 2 years ago

I have just seen that file name is generated by getFileName() function with jpeg extension. However, when testing on Firefox 104.0.2 (for macOS), the downloaded image when PNG format is chose is well named with pngextension. Weird.

RyutoSetsujin commented 2 years ago

This is great! Thank you!

joggee-fr commented 2 years ago

I have just rebased the branch on new master. A minor commit for performance has also been added. Ready to be merged if OK.