search

gurumukhi / youtube-screenshot

Cross browser addon for youtube video screenshots
https://addons.mozilla.org/en-US/firefox/addon/youtube-screenshot-button/
Mozilla Public License 2.0
41 stars 8 forks source link

Colon (:) in filename #29

Closed joggee-fr closed 1 year ago

joggee-fr commented 1 year ago

I have just figured the colon character is used to separate timestamp in filename. Testing the extension with Firefox on macOS, it seems the character is simply replaced by a whitespace in this case. After a bit of research, colon in filename is also forbidden in the Windows world. It should be no worry for Linux however 😃 .

To have a coherent filename through all systems, it may be better to use an other separator e.g. this Chrome extension uses hyphen / minus symbol. What do you think about it ?

gurumukhi commented 1 year ago

Great suggestion, we should fix this. Thanks for pointing it out :)

joggee-fr commented 1 year ago

Separator has been changed in (merged) PR #30.