search

gurumukhi / youtube-screenshot

Cross browser addon for youtube video screenshots
https://addons.mozilla.org/en-US/firefox/addon/youtube-screenshot-button/
Mozilla Public License 2.0
41 stars 8 forks source link

Hot reload configuration #48

Closed joggee-fr closed 1 year ago

joggee-fr commented 1 year ago

This PR replaces PR #32.

This PR mainly add hot reload mechanism when changing add-on preferences. It avoids to refresh the opened YouTube page to apply newly selected options. It works sending message from options script to tabs containing content script. The configuration is then reloaded when receiving such a message.

I have done some tests but of course should be validated by other users here. Thanks.

gurumukhi commented 1 year ago

@joggee-fr do you also want to include the two other draft PRs in next release?

joggee-fr commented 1 year ago

@gurumukhi, if you are OK with this PR I can try to rebase next PR #39 to add the "shift+A" shortcut. I am not yet 100% convinced of PR #38. If there is no user asking for such a feature, I think it can be postponed or simply abandoned.

gurumukhi commented 1 year ago

Ya, we can leave #38 for now. Can you have changes from this PR & from #39 in a branch? I can test both changes together.

joggee-fr commented 1 year ago

Ya, we can leave #38 for now. Can you have changes from this PR & from #39 in a branch? I can test both changes together.

I am not yet ready to rebase PR #39 right now, maybe tomorrow (Paris timezone).

joggee-fr commented 1 year ago

Cherry-picked PR #39 here. Ready to be tested 🚀 .

gurumukhi commented 1 year ago

Tested the changes, looks great to me :-) Thanks a lot @joggee-fr.

I really loved new preferences page <3. I just have few minor suggestions for this page -

Thanks again :)

joggee-fr commented 1 year ago 
* Debug mode on/off option can be put as last one.
* User have to click on radiobutton exactly, can you make all radiobuttons select/deselct based on clicks on text also? e.g. User can just click on on or off instead of their respective radiobuttons.

I have just added two commits for your suggestions.

gurumukhi commented 1 year ago

Thanks a lot @joggee-fr, publishing new version now. We have closed all PRs as of now, if you have time also go through all open issues for cleanup (see if they can be closed/merged together). Thanks. again :)