"Download file" stopped working

gurumukhi / youtube-screenshot

Cross browser addon for youtube video screenshots

https://addons.mozilla.org/en-US/firefox/addon/youtube-screenshot-button/

Mozilla Public License 2.0

43 stars 9 forks source link

"Download file" stopped working #61

Open ThibaultVlacich opened 3 months ago

ThibaultVlacich commented 3 months ago

Extension stopped working, don't really know why. When I click the Screenshot button, the file does not get saved.

I enabled the logging, I see this in the console when I click the button:

Youtube Screenshot Addon: Successfully started download file

But no file is getting downloaded. Firefox 129.0 released two days ago. I feel like it was working just before that, so maybe related?

EDIT: copy to clipboard works fine.

UncookedMoa commented 3 months ago

I am also experiencing this issue, and have found that this seems to only be an issue for specific videos. Some videos don't seem to be able to be screenshotted at all, while others can. Really bizarre.

gurumukhi commented 3 months ago

Thank you very much @ThibaultVlacich and @UncookedMoa for reporting this issue. I think there is an issue in the latest version 4.3.0 which was released this month. For now I have disabled this version and enabled previous version (4.2.0).

gurumukhi commented 3 months ago

Even after reverting back to previous version there seems to be some issues (as per latest reviews). Is this because of YouTube UI changes or some issue in our addon itself?

@joggee-fr

joggee-fr commented 3 months ago

I don't know how versions are managed in AMO. @gurumukhi, did you know if an existing installation is automatically downgraded in such a case? Maybe you should revert the PR here and create a new version to be sure. I can't inspect the issue right now.

gurumukhi commented 3 months ago

Version management on AMO is simple - You can keep uploading new versions and whenever a new version is causing an issue, we can simply disable that version to enable previous one. In this screenshot, you can see I simply disabled 4.3.0 version and now 4.2.0 version is enabled.

You can download current and old version files from https://addons.mozilla.org/en-US/firefox/addon/youtube-screenshot-button/versions/. So, right now the version enabled on the AMO is 4.2.0 and you can check that code at https://github.com/gurumukhi/youtube-screenshot/tree/f09a74e0cae3124d667c170367caeb0bf2b49a04.

ThibaultVlacich commented 3 months ago

It does not auto downgrade indeed. I had to uninstall the extension and re-install it to get the not bugged version.

Maybe you can re-publish the working version as a 4.4.0 ?

joggee-fr commented 2 months ago

@ThibaultVlacich @UncookedMoa What it is the behavior you observe when trying to download the screenshot as a file? No file is really saved in your download directory?

joggee-fr commented 2 months ago

Gentle ping @ThibaultVlacich @UncookedMoa.