search

guruthree / mac-se-video-converter

Convert video from a Mac Plus/SE/Classic to a VESA VGA signal using a Raspberry Pi Pico
78 stars 5 forks source link

Readibility Change #1

Closed Blayzeing closed 1 year ago

Blayzeing commented 1 year ago

I was reading your FAQ and saw the bit about changing the colours and figured this'd make for a slightly nicer time changing that if someone wanted to without having the hassle of copying the values so they knew what they were originally before doing the replace command.

Plus repeated magic numbers make me sad.

I also fixed two small typos in the README.

Though, I don't have the hardware to test my change so while it's small, you might want to double-check that it still compiles/runs.

guruthree commented 1 year ago

2ea4066 is fine, but 5c0075f needs some work to fit in with the code. Constants for black and white are already defined in https://github.com/guruthree/mac-se-video-converter/blob/98c07ab59ec763d6a2889af38c97fbe925ee456c/vga.h#L46-L47 lookuptable should use these and be included into vga.h after the definition.

README.md suggests swapping 0x0000 and 0x7FFF in case the video signal coming from the Mac is inverted, in which case I don't think black and white would be labelled appropriately. I think the better solution would be to add 

#define INVERTED_SIGNAL 0 // change to 1 if colours are inverted

to vga.h and then edit calls afterwards to sebuffer to be ~sebuffer when set. (And then of course update the readme to match...)