guruucsd / lateralized-components

Submission to OHBM 2016 on functional lateralization using the neurovault dataset.
0 stars 2 forks source link

ENH: reorder rows, prioritize by top-2 max difference #20

Closed bcipolli closed 8 years ago

bcipolli commented 8 years ago

This addresses two things:

  1. The component matching was tweaked such that rows with the clearest preference for a column gets to match first (take two lowest distance scores, subtract & normalize, allow largest value to select first).
  2. Rows get reordered according to the same score.
  3. Normalize by subtracting off the lowest similarity score... no division.

@atsuch It's looking reasonable:

r_l_simmat r_l_simmat-normalized

bcipolli commented 8 years ago

@atsuch Looks like this is doing much better matching. The sorting doesn't do too much for me, but the better matching makes the results much more interesting!

I'm seeing two things in both vs. rl:

Some things to do:

atsuch commented 8 years ago

The matching and reordering look fantastic!

As for allowing to reuse matches, I thought about it too, just hadn't got around to discuss it with you. Whether we do comparisons your way (RL to both) or my way (R- or L- only to both), I wasn't sure if we should be forcing one-to-one matching for all the components. We are hypothesizing that some wb components will have good match than others, depending on how much the interhemispheric interactions are affecting the wb component. That's why I wanted to be able to compare match scores not just by rows but across the whole matrix.

Need to go now but will comment more...!

bcipolli commented 8 years ago

Thanks @atsuch ! Feel free to open github issues for individual things to discuss and propose. It's a common way to make conversations focused on code changes, and to make discussions easy to find.

Sounds like this code is the right kind of thing, so I will merge it!