search

guruucsd / lateralized-components

Submission to OHBM 2016 on functional lateralization using the neurovault dataset.
0 stars 2 forks source link

Plot different comparison methods and sources in ps.py #27

Closed bcipolli closed 7 years ago

bcipolli commented 8 years ago

From @atsuch: Add R-, L-, and RL-concat to wb comparison overlaid on top of each other in ps.py

atsuch commented 8 years ago

@bcipolli, I'm trying to implement this in ps.py, but there is something I don't understand in your code. You track the sparsity of images in lines['above_001'], ['above_005'] and ['above_0005'], but these are not incorporated in the plot, are they? Am I missing something?

bcipolli commented 8 years ago

They are plotted here, right? https://github.com/bcipolli/lateralized-components/blob/c53f0891e222037c300ceaac975eecc26457d2b5/ps.py#L54

atsuch commented 8 years ago

Yeah I had trouble understanding that line. So np.asarray(lines.values()) is simply the array version of the dict, but [-1] select only the last element of that array, which are values of lines['err'], no? So I thought you are just plotting normalized lines['err'] here.

bcipolli commented 8 years ago

Ah see, you understood it well! Better than me haha. dict is unordered, so I'm really not sure what the [-1] is doing there. In addition, the legend is commented out. So it looks like I merged some code I was playing around with.

I would remove the [-1] and add back the legend!

atsuch commented 8 years ago

OK, yeah, that's why I was confused...since dict is unordered, it's just by chance we were getting lines['err'] values. So it's actually supposed to show sparsity at different levels in addition to the similarity score. Got it!

bcipolli commented 8 years ago

You are :+1: :+1: :+1:

bcipolli commented 7 years ago

I think we're all set here; I'm closing as fixed by @atsuch .