search

guruucsd / lateralized-components

Submission to OHBM 2016 on functional lateralization using the neurovault dataset.
0 stars 2 forks source link

Issue 52 summarize differences #58

Closed bcipolli closed 7 years ago

bcipolli commented 7 years ago

Try this again; redoing #56 after breaking everything with a badly done push...

bcipolli commented 7 years ago

@atsuch could you take a look at this code (and the referenced PR for details)?

I just ran this on my machine, and it works great:

python main.py --offline

atsuch commented 7 years ago

There is a small error when getting the sign, which I fixed here. 18f623bccbfa8b264af83c3761b893b42f3af939

And then I started to think about a larger issue of how to make it more general, since this plot ignores unmatched R/L components. The commits following the one above (in my issue-52 branch) are small bug fixes and still-WIP refactoring of the codes. But maybe I should have closed this issue after the 18f623 and started a new branch...

bcipolli commented 7 years ago

maybe I should have closed this issue after the 18f623 and started a new branch...

Sounds like a good idea to me. Better to work incrementally on accepted code, than lose track of whether a piece of code is viable at all.

I've cherry-picked that commit; I recommend merging this and continuing on what you were doing!