gus33000 / UUPMediaCreator

An utility to create Windows Media files (.ISO, .WIM, .VHD) from Unified Update Platform files
MIT License
781 stars 66 forks source link

When making Windows 10 images, install.wim identifies most SKUs as Windows 11 #125

Open XenoPanther opened 2 years ago

XenoPanther commented 2 years ago

I just finished making a 18362.1 ISO and noticed that most SKUs report "Windows 11". I suspect it's naming all virtual SKUs as Windows 11 image

gus33000 commented 2 years ago

Yeah this would require dynamically reading the sku name from basebrd, something I haven't figured out how to exactly do yet because it's going through a mess of NtQuerySystemInformation calls and the ids in the mui don't match the sku id itself (and differ between server/client). You can always edit the Settings.ini file for now to correct the names.

stdin82 commented 1 year ago

Why not read or check the base image name (Home/Pro)? or just assume that any > 21900 build is Windows 11

gus33000 commented 1 year ago

Some skus don't use client branding and the part after Windows XX also needs to match the current branding as well. But I agree this could be a good solution for now