Closed AnubyteCode closed 1 month ago
Hi. Thanks for your contribution. I however can't accept it for many reasons. Some of the changes deviate way too much from the intended program behavior. Others I'm not for. And some introduce comments that are not in English and personally not needed.
I don't want to sound negative however but I personally don't see these changes fitting with the direction of this tool.
This tool is also used in production, some of the changed behaviors would impact those customers and go against their will (command line, console output too).
The list of architecture is on purpose limited to what the windows update servers support at the moment by design
Some of the enum are shared code compenents and the edits lack all options of before
Lastly, the way the copyrights are printed on startup cannot be changed as per license requirement. Modifying those would infringe upon the license.
Most of the things I have done are updating the readme to contain more info, updating the help to contain the same, adding .txt that has an expanded list of SKUs people can choose from to look up, expanded CTAC to containt the expansions, revealed you can use a number instead of a longname for editions, and trialing a few networking settings which initial trials suggest are at least not regressive.