search

gusbemacbe / suru-plus-aspromauros

A Suru++-like monochromatic icons theme for users of dark environments
GNU General Public License v3.0
58 stars 6 forks source link

Icons missing "?" in Elisa #11

Open Roboron3042 opened 5 years ago

Roboron3042 commented 5 years ago

First and foremost, thank you very much for cyberpunkneoning this theme, it's SUPERB. I'm enjoying it very much.

Second, I've been using it system-wide and i have found some icons are missing in Elisa music player (even some basic icons like the "song" icon I'm sure this theme has... weird).

Here is a comparative between Papirus-Dark icons and Suru++ Asprómauros icons in Elisa.

Papirus Suru++ Papirus Suru++

Again, thank you for your work ^.^

gusbemacbe commented 5 years ago

I have just fixed Oomox issue and also fixed more or less than 200 icons which did not have exactly fill="currentColor" class="ColorScheme-Text", causing them to be gone. I will test on Elisa.

gusbemacbe commented 5 years ago

It seems that it does not have certain icons of Elisa, I will investigate why these icons are not rendered correctly:

image

gusbemacbe commented 5 years ago

Strange, Suru++ Asprómauros has this icon, but not rendered correctly in Elisa:

image

@SmartFinn, is this icon name exactly favorite-genres-amarok.svg?

gusbemacbe commented 5 years ago

Hello @SmartFinn and @Roboron3042 !

I found the icons names:

https://github.com/KDE/elisa/blob/7dbdbc31c20a467b030e8a1dc751926a43fdeffc/src/models/viewsmodel.cpp#L53-L60

I searched all these icons names in Papirus and in Suru++, all they are not present, except amarok_playcount, view-media-artist, view-media-playlist and document-open-folder.

image