search

gusbemacbe / suru-plus-telinkrin

Based on the Suru++ and Sam Hewitt's Suru Icons adapted to the Telinkrin GTK theme
GNU Lesser General Public License v3.0
14 stars 1 forks source link

Stop this immediately! It breaks the gnome system #7

Open paullinuxthemer opened 6 years ago

paullinuxthemer commented 6 years ago

Hello,

This is Paul Beyens, I've tested the download-file you supply and put it in the '.icons'-folder. After selecting it in gnometweaks is immediately closes gnome-tweaks and nautilus does not fire up any more. Which leaves you with no means to remove the icon-theme. Had to fire up 'sudo-nautilus' for root-acces. This way I could remove the file from my '.icons' folder, log out and back in, and finally choose another icontheme.

So what happenend? There are to many files in the download-file that should not be there. After removing

gusbemacbe commented 6 years ago

Hello @paullinuxthemer,

You were right. But I removed only icon-theme.cache and it worked now. As you have suggested me to remove a lot of these files, not icon-theme.cache, I will consider to remove these files from my repository.

But the cursor.theme and cursors? It is always contained in Andrea's icons themes without icon-theme.cache and without .git and it works normally. It must because only of icon-theme.cache and of .git*.

gusbemacbe commented 6 years ago

So, make a special file (with only the necessary files) and upload that to Gnome-Look.org, and NOT the github-link.

I have just removed the unnecessary files. But and the cursors and cursor.theme?

See https://github.com/Magog64/SURU-PLUS. It contains cursors and cursors.theme.

paullinuxthemer commented 6 years ago

Well, I have not tested it all, just removed the obvious ones.
While Andrea may have added a cursortheme, it it generally not considered to be part of an icon-theme. There is a separate category for that on gnome-look.org.
Nevertheless letting people downloading github-files directly is not something I do. Because there's usually much more on it, than people need. People are lazy, and if it does not work properly, you loose allot of your reputation. My advice is: be certain, that what you give people actually works out of the box. Keep it simple. An icontheme should be simply drag and drop in the '.icons'-folder.

paullinuxthemer commented 6 years ago

Next, I noticed, that you use symbolic icons for categories. Which no other icontheme does. If you use the Arc-menu (standard on Manjaro-gnome (which I use)) the categories are symbolic. scr

gusbemacbe commented 6 years ago

Next, I noticed, that you use symbolic icons for categories. Which no other icontheme does. If you use the Arc-menu (standard on Manjaro-gnome (which I use)) the categories are symbolic.

I have never created the symbolic icons. Magog64 created it. I created only 381 icons (I have never created applications-* icons) on the folder apps.

We are not aware of the existence of Arc Menu. Magog64 works only with Ubuntu and does not wish to test on several distributions, therefore, I assume the responsibility. Before I installed every distribution, analysed the missed icons and reported to Magog64.

I will install GNOME and Arc Menu on my Manjaro to find which icons are missed.

If it does not work on Arc Theme, Numix and Papirus are the only salvation to solve my icons themes issues.

Nevertheless letting people downloading github-files directly is not something I do. Because there's usually much more on it, than people need. People are lazy, and if it does not work properly, you loose allot of your reputation. My advice is: be certain, that what you give people actually works out of the box. Keep it simple. An icontheme should be simply drag and drop in the '.icons'-folder.

I added a new Github-linked version of this icons themes since those unnecessary files were removed as you have suggested.

Please, only a quick and small test and see if it works.

https://www.opendesktop.org/p/1245676/

I hope it do not break the system after removing all the unnecessary files as you have suggested me.