gusbemacbe / suru-plus

Suru++ 25 — A cyberpunk, elegant, futuristic and Papirus-like third-party icons theme
GNU General Public License v3.0
344 stars 32 forks source link

Buttons invsible in evolution mail client #10

Closed venorz closed 6 years ago

venorz commented 6 years ago

Hello,thanks for your great works. I really love this icon theme. Here I found a problem with my evolution mail client. Icons below the menu bar are invisible. Please look at the below pictures, you can see the difference between default and SURU++ theme.

Default: screenshot from 2018-05-22 20-02-28 SURU++: screenshot from 2018-05-22 20-02-01 Deault: screenshot from 2018-05-22 20-03-49 SURU++: screenshot from 2018-05-22 20-04-18

gusbemacbe commented 6 years ago

Hi @venorz, are you using dark or light environment theme?

venorz commented 6 years ago

@gusbemacbe Hi, thanks for your reply. Not sure what do you mean by light or dark theme, I'm using the default Ambiance theme on 18.04 LTS.

gusbemacbe commented 6 years ago

Suru++ is designed for light themes. If we change the grey icons to white and white icons will be also invisible in other places, like Inkscape. See if Suru++ Dark solves this problem with Evolution app.

gusbemacbe commented 6 years ago

Using Ambiance, Suru++ Dark worked on Evolution, but not on Inkscape, you can see:

image

gusbemacbe commented 6 years ago

As I switched to Suru++, it worked on Inkscape, but not on Evolution:

image

gusbemacbe commented 6 years ago

I and Andrea have to think and be careful to select for not messing the icons in different apps.

venorz commented 6 years ago

Sorry, I left for a while. Looks like both normal and dark version SURU++ can not fit every app. how about colored icons which are similar to default ones, is that far from SURU's design concept?

gusbemacbe commented 6 years ago

Good question and good idea. I'll talk about it with Andrea and let's see if he will reconsider this concept.

gusbemacbe commented 6 years ago

What worries me is that others users can not like or won't be happy with the coloured actions icons, principally in the dark icons theme. They want to use the white and uncoloured icons theme which fits perfectly in apps adapted to the dark environment.

We will think about it. Let's see Andrea's decision in relation to this design concept.

gusbemacbe commented 6 years ago

I have an idea. What about replacing grey for orange in the case of actions icons?

venorz commented 6 years ago

I'm not sure about that, but I will be happy to give it a try. Maybe it will works, orange fits Ambiance and Ubuntu.

Bonandry commented 6 years ago

I thought to fill the icons for Evolution with a 30/40% of white, what do you think?

Il mar 22 mag 2018 16:19 venorz notifications@github.com ha scritto:

I'm not sure about that, but I will be happy to give it a try. Maybe it will works, orange fits Ambiance and Ubuntu.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Magog64/SURU-PLUS/issues/10#issuecomment-391008059, or mute the thread https://github.com/notifications/unsubscribe-auth/AHlswWTCU-l1Vz4cTjtmEZPvsHHkyvTPks5t1B5_gaJpZM4UIiQ1 .

gusbemacbe commented 6 years ago

@Magog64 we also need to check if the icons for Evolution will also for other apps with light bar.

Bonandry commented 6 years ago

there would be no problems because the contours remain dark, now I'm at work tonight I do a test and then we decide

Il mer 23 mag 2018 07:30 Gustavo Reis notifications@github.com ha scritto:

@Magog64 https://github.com/Magog64 we also need to check if the icons for Evolution will also for other apps with light bar.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Magog64/SURU-PLUS/issues/10#issuecomment-391225213, or mute the thread https://github.com/notifications/unsubscribe-auth/AHlswa41XABOWEN2bZ9Qp630WiLkJ-D5ks5t1PP4gaJpZM4UIiQ1 .

Bonandry commented 6 years ago

four tests grey 808080 schermata da 2018-05-23 12-18-58

grey with white 100% schermata da 2018-05-23 12-20-28

white ffffff schermata da 2018-05-23 12-21-34

orange schermata da 2018-05-23 12-26-40

Bonandry commented 6 years ago

update, all grey schermata da 2018-05-23 13-03-35

Bonandry commented 6 years ago

my proposal is not perfect but can be used both with the Ambiance theme and with other light schermata da 2018-05-23 18-13-22

gusbemacbe commented 6 years ago

As we have decided, we have updated the icons, @venorz.

Bonandry commented 6 years ago

I have updated all gray / light until I find a better solution

venorz commented 6 years ago

Thanks, I didn't expect that you will fix it so quickly and it is usable now with Evolution. Again,thank you.

gusbemacbe commented 6 years ago

AS @venorz has solved, we close the issue. If case there is a problem, we reopen the issue.