gusbemacbe / suru-plus

Suru++ 25 — A cyberpunk, elegant, futuristic and Papirus-like third-party icons theme
GNU General Public License v3.0
337 stars 32 forks source link

Add vnote and listen1 icons #108

Closed roachsinai closed 5 years ago

roachsinai commented 5 years ago

Could you please add icons for:

gusbemacbe commented 5 years ago

Added. Please update, using that same command in another issue.

roachsinai commented 5 years ago

Thanks! May I asked one more question?

Like vnote icon, the origin is located in theme hicolor.

After I launch vnote application, there is a vnote icon in system tray with hicolor theme one used.

Is there a way to let system tray use Suru++ theme one? Without use Suru++ icon override the icon of hicolor.

gusbemacbe commented 5 years ago

It means that vnote's desktop file does not have icon code, or is using the fixed icon path or icon generic name. Please, check:

You need to modify manually the vnote's desktop file at /usr/share/applications or ~/.local/share/applications.

roachsinai commented 5 years ago

desktop file for listen1

[Desktop Entry]
Name=Listen1
Comment=One for all free music in China
Exec=env DESKTOPINTEGRATION=no "/opt/appimages/listen1.AppImage" %U
Terminal=false
Type=Application
Icon=listen1
StartupWMClass=Listen1
X-AppImage-Version=2.1.5
Categories=Utility;
X-AppImage-BuildId=1HvKDJ3EUJMJwm6YxKB8wQfQx3p

But I got the original icon:

image

Maybe the reason is that listen1 is a appimage application?

gusbemacbe commented 5 years ago

Yes, AppImageLauncher creates the desktop file automatically. If you modify again, AppImageLauncher will revert when you open the AppImage. Please check:

https://github.com/gusbemacbe/suru-plus/tree/beta#appimage-built-apps

roachsinai commented 5 years ago

Thanks for you instructions!

My listen1.desktop file content at /usr/share/applications and /home/roach/.local/share/applications:

[Desktop Entry]
Name=Listen1
Comment=One for all free music in China
Exec=env DESKTOPINTEGRATION=no "/opt/appimages/listen1.AppImage" %U
Terminal=false
Type=Application
Icon=listen1
StartupWMClass=listen1
X-AppImage-Version=2.1.5
Categories=Utility;
X-AppImage-BuildId=1HvKDJ3EUJMJwm6YxKB8wQfQx3p

I have removed appimagelauncher and rebooted. But, still not work.


btw, sudo StartupWMClassFixer is not work for https://github.com/bilelmoussaoui/StartupWMClassFixer, have to use sudo /opt/StartupWMClassFixer/fix.

gusbemacbe commented 5 years ago

Change StartupWMClass=listen1 to StartupWMClass=Listen1 because of Name given to an AppImage.

Remove X-AppImage-Version=2.1.5 and X-AppImage-BuildId=1HvKDJ3EUJMJwm6YxKB8wQfQx3p.

Change Exec=env DESKTOPINTEGRATION=no "/opt/appimages/listen1.AppImage" %U to Exec=/opt/appimages/listen1.AppImage. As AppImageLauncher is removed, no need to keep env DESKTOPINTEGRATION=no.

gusbemacbe commented 5 years ago

After finishing, you need to update the database cache in the terminal if you do not want to reboot again.

roachsinai commented 5 years ago

Hi, @gusbemacbe , I have rebooted.

Seems don't know what's wrong.

hmank ~ > cat .local/share/applications/listen1.desktop 
[Desktop Entry]
Name=Listen1
Comment=One for all free music in China
Exec=/opt/appimages/listen1.AppImage
Terminal=false
Type=Application
Icon=listen1
StartupWMClass=Listen1
Categories=Utility;
hmank ~ > ll /usr/share/icons/Suru++/apps/16 | grep listen
-rw-r--r-- 1 root root 2.7K 3月  16 14:04 listen1.svg
roachsinai commented 5 years ago

And should I use sudo gtk-update-icon-cache /usr/share/icons/Suru++ to update cache no need reboot?

gusbemacbe commented 5 years ago

Yes, it generates the new icon cache to remove old cache.

You can use Stacer to clean the old caches of icons and of desktop files without needing to reboot.

gusbemacbe commented 5 years ago

Maybe of Exec=/opt/appimages/listen1.AppImage, because it is rooted.

roachsinai commented 5 years ago

I've move it to other places. But not work, too.

But, thanks a lot for the help so far.

gusbemacbe commented 5 years ago

Tonight I'll test Listen1. I'm at college now.

roachsinai commented 5 years ago

That's great!!!

gusbemacbe commented 5 years ago

Hi @roachsinai !

It worked here, and I will send a zipped desktop.

imagem

  1. Create the folder Applications/AppImages in your home folder.
  2. Move AppImage to the ~/Applications/AppImages/
  3. Rename the AppImage listen1 to Listen1. Make it executable and trusting, using the command chmod a+x Listen1.AppImage.
  4. Extract the zip, open the desktop file and change /data/Gustavo/Applications/AppImage/Listen1.AppImage to $HOME/Applications/AppImages/Listen1.AppImage
  5. Move the desktop file to ~/.local/share/applications/
  6. Ready.

Listen1.tar.gz

roachsinai commented 5 years ago

Hi, does the icon shows on system tray is located at Suru++/panel?

As I found vnote and dropbox svg at Suru++/apps is Screenshot_20190317_100643

But, dropbox color could be white at tray

image

And, last I found there is dropboxstatus-idle.svg under Suru++/panel/16.

gusbemacbe commented 5 years ago

@roachsinai

Do not confuse apps with panel. The dropbox.svg and vnote.svg of apps is for applications icons and not for Dropbox and VNote status panel icon.

Hi, does the icon shows on system tray is located at Suru++/panel?

It does not have VNote status icon. I need to download VNote and find the icons.

gusbemacbe commented 5 years ago

Then icons are vnote_ink, vnote_small and vnote_update, according to https://github.com/tamlok/vnote/tree/master/src/resources/icons. I will add to panel.

gusbemacbe commented 5 years ago

Hi @roachsinai

Added.

Run the command:

wget -qO- https://raw.githubusercontent.com/gusbemacbe/suru-plus/beta/install.sh | TAG=beta sh
roachsinai commented 5 years ago

Thanks!!!