search

gusbemacbe / suru-plus

Suru++ 25 — A cyberpunk, elegant, futuristic and Papirus-like third-party icons theme
GNU General Public License v3.0
337 stars 32 forks source link

elementary os icon bug #109

Closed Chamrosh closed 5 years ago

Chamrosh commented 5 years ago

mail app Screenshot from 2019-03-11 21 18 23

code Screenshot from 2019-03-11 21 18 49

photos Screenshot from 2019-03-11 21 19 12

gusbemacbe commented 5 years ago

These colorful icons are 32px. Other monochromatic icons are 24px. The eSuru++ inherits from Suru++.

I have to modify eSuru++.

gusbemacbe commented 5 years ago

HI @Chamrosh

Firstly you update Suru++ and then eSuru++, run in the terminal:

wget -qO- https://raw.githubusercontent.com/gusbemacbe/suru-plus/master/install.sh | TAG=beta THEMES=Suru++ sh
wget -qO- https://raw.githubusercontent.com/gusbemacbe/suru-plus/master/install.sh | TAG=beta THEMES=eSuru++ sh

See if it works.

Chamrosh commented 5 years ago

Screenshot from 2019-03-13 20 07 54

gusbemacbe commented 5 years ago

@Chamrosh

I will install elementary OS Code app on Manjaro to investigate the icons.

gusbemacbe commented 5 years ago

@SmartFinn !

What is the name of this blue folder with magnifying glass icon in your icons theme ePapirus?

imagem

SmartFinn commented 5 years ago

@gusbemacbe folder-saved-search

gusbemacbe commented 5 years ago

@SmartFinn Strange, the folder-saved-search.svg that I found on my icons themes, is not wrong, so it is a folder with glass and not only a glass.

gusbemacbe commented 5 years ago

@Chamrosh

I finally figured the icon. It was in the eSuru++, copeid from ePapirus. The icon of both eSuru++ and ePapirus was wrong. I fixed. Please update, using the same commands above.

I will alert @SmartFinn ans @varlesh.

In ePapirus, in the folders 16, 22 and 24, the iconfolder-search.svg is wrong, so in the elementary OS Code app, the colourful icon of folder-search.svg is shown instead of monochromatic icon. But if I resymlink 16 to 22 and 24, there will be two same magnifying glass icons in the elementary OS Code app.

You need to redesign the icon. A folder with magnifying glass and not just a magnifying glass.

SmartFinn commented 5 years ago

@gusbemacbe I added a workaround for the icon before https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/issues/1510 and now I see that is not working. To make it display correctly I have to remove folder-saved-search from places and left it in actions, but I don't sure that is right.

gusbemacbe commented 5 years ago

@SmartFinn

Then in the ePapirus/16x16/places/, it does not have folder-search.svg which seems to be a new icon of elementary OS Code app.

Ah, I got,

ePapirus/22x22/places is symlinked to Papirus/22x22/places which is colourful. You need to resymlink ePapirus/16x16/places/ to ePapirus/22x22/places/. If it does not work, keep that, then also resymlink to ePapirus/24x24/places/

Do not forget of adding the folder-search.svg in the 22, 24, 32, 48 and 64 folders.

SmartFinn commented 5 years ago

@gusbemacbe there no folder-search icon, it's folder-saved-search

https://github.com/elementary/code/blob/1b5ffc5468e61791a88bddf7391d5265be2458f1/src/Widgets/HeaderBar.vala#L46 https://github.com/elementary/code/blob/e0f239f11ed928907e0661f6a39727447803a4eb/src/Widgets/WelcomeView.vala#L34

You need to resymlink ePapirus/16x16/places/ to ePapirus/22x22/places/

It's a dirty hack, we don't use it.

gusbemacbe commented 5 years ago

Ok, @SmartFinn, maybe better let @codygarver, @roymckenzie and @danrabbit. They may have knowledge of this problem.