search

gusbemacbe / suru-plus

Suru++ 25 — A cyberpunk, elegant, futuristic and Papirus-like third-party icons theme
GNU General Public License v3.0
343 stars 32 forks source link

Update ffsvg wanted #110

Closed gusbemacbe closed 5 years ago

gusbemacbe commented 5 years ago

Hello @SmartFinn !

I am not expert in Bash and in Python.

The problem is that ffsvg will remove the list of 9 gradients and will shorten #ffffff to #fff.

I would like to preserve the gradients list and the 6 numbers of colour hexadecimal code. And I would like ffsvg convert #UPPERCASE-COLOURS to #lowercase-colours.

Is there way to update it?

SmartFinn commented 5 years ago

But ffsvg can't do this. You can check it by running:

cd scripts/
./ffsvg.sh list-colours.svg
git difftool

The hex codes are left as is and the gradients are not removed. I suppose the changes are made by your editor.

gusbemacbe commented 5 years ago

The hex codes are left as is and the gradients are not removed. I suppose the changes are made by your editor.

I did a test. The ffsvg did not remove the gradients of list-colours.svg, but removed the gradients of a new SVG icon test.

SmartFinn commented 5 years ago

How can I reproduce it? Could you upload the icon that will be broken with ffsvg?

gusbemacbe commented 5 years ago

Hi, @SmartFinn

Ready. You can test with the icon listen1.svg which contains 9 gradients list.

SmartFinn commented 5 years ago

No gradients are removed. Do you use svgo or scour? Try to update svgo to the latest version npm install -g svgo

SmartFinn commented 5 years ago

I got it. scour removes the gradients. Just install svgo using the command above. We don't use scour in our projects, it added like a fallback for new contributors.

gusbemacbe commented 5 years ago

Ah, I used both scour and svgo manually. I installed globally, and I tested, and the gradients are not removed. I have to keep one plugin globally and not manually.

Thank you!

gusbemacbe commented 5 years ago

Do not forget of reading my alert I have to you and Alex in the reference #109, @SmartFinn .

gusbemacbe commented 5 years ago

Hello @SmartFinn !

Please, can you update install.sh, for not just downloading Suru++, but also eSuru++ and Suru++-Light?

I am afraid of damaging the file.

SmartFinn commented 5 years ago

@gusbemacbe just change the line https://github.com/gusbemacbe/suru-plus/blob/master/install.sh#L8 to : "${THEMES:=Suru++ Suru++-Light eSuru++}"