gusbemacbe / suru-plus

Suru++ 25 — A cyberpunk, elegant, futuristic and Papirus-like third-party icons theme
GNU General Public License v3.0
344 stars 32 forks source link

Some bugs in the icon theme #31

Closed SmartFinn closed 5 years ago

SmartFinn commented 5 years ago

List of icons with renderer issues

You can ignore this section if you don't want to support old distros with GTK2 (like Ubuntu 14.04).

To fix it, disable removing leading zero in your SVG cleaner and resave the following icons:

272 icons with the render issue ``` ./actions/16/bookmark-remove.svg ./actions/16/call-stop.svg ./actions/16/camera-switch.svg ./actions/16/colors-chromablue.svg ./actions/16/colors-chromagreen.svg ./actions/16/colors-chromared.svg ./actions/16/deep-history.svg ./actions/16/document-close.svg ./actions/16/draw-ellipse-arc.svg ./actions/16/draw-ellipse-segment.svg ./actions/16/draw-halfcircle1.svg ./actions/16/draw-halfcircle2.svg ./actions/16/draw-halfcircle3.svg ./actions/16/draw-halfcircle4.svg ./actions/16/draw-star.svg ./actions/16/draw-triangle1.svg ./actions/16/draw-triangle2.svg ./actions/16/edit-select.svg ./actions/16/edit.svg ./actions/16/error-correct.svg ./actions/16/feed-subscribe.svg ./actions/16/fill-rule-even-odd.svg ./actions/16/fill-rule-nonzero.svg ./actions/16/final_activity.svg ./actions/16/format-border-style.svg ./actions/16/games-solve.svg ./actions/16/get-hot-new-stuff.svg ./actions/16/go-down.svg ./actions/16/go-next.svg ./actions/16/go-previous.svg ./actions/16/go-up.svg ./actions/16/help-about.svg ./actions/16/im-facebook.svg ./actions/16/im-skype.svg ./actions/16/im-user-busy.svg ./actions/16/im-user-offline.svg ./actions/16/im-user-online.svg ./actions/16/im-user.svg ./actions/16/insert-button.svg ./actions/16/kr_syncbrowse_off.svg ./actions/16/kr_syncbrowse_on.svg ./actions/16/license.svg ./actions/16/link-edit.svg ./actions/16/list-remove-user.svg ./actions/16/mail-mark-junk.svg ./actions/16/mail-signature-unknown.svg ./actions/16/mail-signed-full.svg ./actions/16/mail-signed-part.svg ./actions/16/mail-signed-verified.svg ./actions/16/mail-unread-multiple.svg ./actions/16/media-playlist-shuffle.svg ./actions/16/new-audio-alarm.svg ./actions/16/package-available-locked.svg ./actions/16/package-broken.svg ./actions/16/package-downgrade.svg ./actions/16/package-install.svg ./actions/16/package-installed-outdated.svg ./actions/16/package-installed-updated.svg ./actions/16/package-new.svg ./actions/16/package-purge.svg ./actions/16/package-remove.svg ./actions/16/package-upgrade.svg ./actions/16/paint-swatch.svg ./actions/16/path-simplify.svg ./actions/16/player-volume.svg ./actions/16/shutdown_highlight.svg ./actions/16/sidebar-places.svg ./actions/16/snap-nodes-intersection.svg ./actions/16/stroke-cap-round.svg ./actions/16/stroke-join-bevel.svg ./actions/16/stroke-join-round.svg ./actions/16/symbols.svg ./actions/16/tag.svg ./actions/16/tools-wizard.svg ./actions/16/transform-affect-gradient.svg ./actions/16/view-close.svg ./actions/16/view-web-browser-dom-tree.svg ./actions/22/acrobat.svg ./actions/22/adjustrgb.svg ./actions/22/align-horizontal-left-out.svg ./actions/22/align-horizontal-left-to-anchor.svg ./actions/22/align-vertical-bottom-out.svg ./actions/22/align-vertical-top-out.svg ./actions/22/anchor.svg ./actions/22/call-start.svg ./actions/22/call-stop.svg ./actions/22/chronometer.svg ./actions/22/code-context.svg ./actions/22/code-typedef.svg ./actions/22/color-picker-black.svg ./actions/22/color-picker-grey.svg ./actions/22/color-picker-white.svg ./actions/22/color-picker.svg ./actions/22/colorneg.svg ./actions/22/contrast.svg ./actions/22/debug-step-into-instruction.svg ./actions/22/debug-step-into.svg ./actions/22/debug-step-out.svg ./actions/22/debug-step-over.svg ./actions/22/deep-history.svg ./actions/22/dialog-cancel.svg ./actions/22/dialog-messages.svg ./actions/22/dialog-ok-apply.svg ./actions/22/dialog-xml-editor.svg ./actions/22/distribute-horizontal-page.svg ./actions/22/document-decrypt.svg ./actions/22/document-edit-decrypt-verify.svg ./actions/22/document-edit-decrypt.svg ./actions/22/document-edit-sign-encrypt.svg ./actions/22/document-edit-sign.svg ./actions/22/document-edit.svg ./actions/22/document-import.svg ./actions/22/document-new.svg ./actions/22/document-open-remote.svg ./actions/22/document-open.svg ./actions/22/document-preview-archive.svg ./actions/22/document-revert.svg ./actions/22/document-share.svg ./actions/22/dontknow.svg ./actions/22/draw-bezier-curves.svg ./actions/22/draw-brush.svg ./actions/22/draw-calligraphic.svg ./actions/22/draw-path.svg ./actions/22/draw-polygon.svg ./actions/22/draw-polyline.svg ./actions/22/draw-square-inverted-corners.svg ./actions/22/draw-triangle2.svg ./actions/22/earthquake.svg ./actions/22/edit-bomb.svg ./actions/22/edit-cut.svg ./actions/22/edit-guides.svg ./actions/22/edit-image-face-add.svg ./actions/22/edit-image-face-detect.svg ./actions/22/edit-image-face-recognize.svg ./actions/22/edit-image-face-show.svg ./actions/22/edit-link.svg ./actions/22/edit-node.svg ./actions/22/edit-redo.svg ./actions/22/edit-select-invert.svg ./actions/22/edit-undo.svg ./actions/22/extract-archive.svg ./actions/22/filename-and-amarok.svg ./actions/22/filename-filetype-amarok.svg ./actions/22/fill-color.svg ./actions/22/flag-black.svg ./actions/22/flag-blue.svg ./actions/22/flag-green.svg ./actions/22/flag-red.svg ./actions/22/flag-yellow.svg ./actions/22/flag.svg ./actions/22/folder-new.svg ./actions/22/folder-sync.svg ./actions/22/fork.svg ./actions/22/format-add-node.svg ./actions/22/format-line-spacing-normal.svg ./actions/22/go-down.svg ./actions/22/go-home.svg ./actions/22/go-next-context.svg ./actions/22/go-next.svg ./actions/22/go-previous-context.svg ./actions/22/go-previous.svg ./actions/22/go-up.svg ./actions/22/im-kick-user.svg ./actions/22/im-user-away.svg ./actions/22/im-user-busy.svg ./actions/22/irc-unvoice.svg ./actions/22/labplot-shift-down-y.svg ./actions/22/labplot-shift-left-x.svg ./actions/22/labplot-shift-right-x.svg ./actions/22/labplot-shift-up-y.svg ./actions/22/mail-archive.svg ./actions/22/process-stop.svg ./actions/22/shutdown_highlight.svg ./actions/22/skrooge_credit_card.svg ./actions/22/stroke-cap-round.svg ./actions/22/stroke-join-bevel.svg ./actions/22/stroke-join-round.svg ./actions/22/timeline-use-zone-off.svg ./actions/22/view-bank-account-savings.svg ./actions/22/view-task.svg ./actions/22/window-close.svg ./actions/24/acrobat.svg ./actions/24/call-stop.svg ./actions/24/color-picker-black.svg ./actions/24/color-picker-grey.svg ./actions/24/color-picker-white.svg ./actions/24/document-decrypt.svg ./actions/24/document-edit-decrypt-verify.svg ./actions/24/document-edit-decrypt.svg ./actions/24/document-edit-sign-encrypt.svg ./actions/24/document-edit.svg ./actions/24/document-new.svg ./actions/24/document-open-remote.svg ./actions/24/document-open.svg ./actions/24/document-revert.svg ./actions/24/edit-bomb.svg ./actions/24/edit-cut.svg ./actions/24/edit-guides.svg ./actions/24/edit-image-face-add.svg ./actions/24/edit-image-face-detect.svg ./actions/24/edit-image-face-recognize.svg ./actions/24/edit-image-face-show.svg ./actions/24/edit-redo.svg ./actions/24/edit-undo.svg ./actions/24/fill-color.svg ./actions/24/shutdown_highlight.svg ./actions/32/acrobat.svg ./actions/32/archive-remove.svg ./actions/32/call-start.svg ./actions/32/call-stop.svg ./actions/32/color-picker.svg ./actions/32/colors-chromablue.svg ./actions/32/colors-chromagreen.svg ./actions/32/colors-chromared.svg ./actions/32/colors-luma.svg ./actions/32/dialog-ok-apply.svg ./actions/32/document-close.svg ./actions/32/edit-redo.svg ./actions/32/edit-undo.svg ./actions/32/media-optical-audio-new.svg ./actions/32/stock_xfburn-audio-cd.svg ./actions/32/view-preview.svg ./actions/symbolic/appointment-symbolic.svg ./actions/symbolic/browser-download-symbolic.svg ./actions/symbolic/camera-switch-symbolic.svg ./actions/symbolic/close-symbolic.svg ./actions/symbolic/error-correct-symbolic.svg ./actions/symbolic/shutdown_highlight-symbolic.svg ./actions/symbolic/sidebar-places-symbolic.svg ./actions/symbolic/zoom-fit-symbolic.svg ./apps/16/application-default-icon.svg ./apps/16/bug/bug.svg ./apps/16/cs-default-applications.svg ./apps/16/desktopconnected.svg ./apps/16/game/game.svg ./apps/16/gnome-do.svg ./apps/16/help/help.svg ./apps/16/kali-menu.svg ./apps/16/kolf.svg ./apps/16/preferences-desktop-theme.svg ./apps/16/webcam/webcam.svg ./apps/16/xbmc.svg ./apps/16/xnsketch.svg ./apps/symbolic/application-default-icon-symbolic.svg ./apps/symbolic/bug/bug-symbolic.svg ./apps/symbolic/cs-default-applications-symbolic.svg ./apps/symbolic/desktopconnected-symbolic.svg ./apps/symbolic/game/game-symbolic.svg ./apps/symbolic/gnome-do-symbolic.svg ./apps/symbolic/help/help-symbolic.svg ./apps/symbolic/kali-menu-symbolic.svg ./apps/symbolic/kolf-symbolic.svg ./apps/symbolic/webcam/webcam-symbolic.svg ./apps/symbolic/xbmc-symbolic.svg ./apps/symbolic/xnsketch-symbolic.svg ./categories/16/applications-debugging.svg ./categories/16/applications-education.svg ./categories/16/applications-geology.svg ./categories/16/applications-science.svg ./categories/16/system-help.svg ./categories/symbolic/applications-debugging-symbolic.svg ./categories/symbolic/applications-education-symbolic.svg ./categories/symbolic/applications-geology-symbolic.svg ./categories/symbolic/applications-science-symbolic.svg ./categories/symbolic/system-help-symbolic.svg ./places/16/folder-activities.svg ./places/symbolic/folder-activities-symbolic.svg ./status/16/desktopconnected.svg ./status/16/desktoptrusted.svg ./status/16/network-offline.svg ./status/symbolic/desktopconnected-symbolic.svg ./status/symbolic/desktoptrusted-symbolic.svg ./status/symbolic/network-offline-symbolic.svg ```

List of icons with bitmap images

This is similar to gusbemacbe/suru-plus-alpha#6

List of broken symlinks

List of files with invalid filenames

The following files make impossible to create icon cache:

$ > gtk-update-icon-cache -f .
gtk-update-icon-cache: The generated cache was invalid.

List of files with executable bit

Files in this section have the executable bit that is a security issue.

370 files with the executable bit ``` ./actions/16/brisk_system-log-out-symbolic.svg ./actions/symbolic/star-new-symbolic.svg ./animations/24/nm-stage01-connecting01.svg ./animations/24/nm-stage01-connecting02.svg ./animations/24/nm-stage01-connecting03.svg ./animations/24/nm-stage01-connecting04.svg ./animations/24/nm-stage01-connecting05.svg ./animations/24/nm-stage01-connecting06.svg ./animations/24/nm-stage01-connecting07.svg ./animations/24/nm-stage01-connecting08.svg ./animations/24/nm-stage01-connecting09.svg ./animations/24/nm-stage01-connecting10.svg ./animations/24/nm-stage01-connecting11.svg ./animations/24/nm-stage01-connecting12.svg ./apps/16/AdobeAfterEffect.svg ./apps/16/AdobeAudition.svg ./apps/16/AdobeBridge.svg ./apps/16/AdobeDreamweaver.svg ./apps/16/AdobeEncore.svg ./apps/16/AdobeFirework.svg ./apps/16/AdobeFlashBuilder.svg ./apps/16/AdobeIllustrator.svg ./apps/16/AdobeIndesign.svg ./apps/16/AdobeLightroom.svg ./apps/16/AdobeMediaEncore.svg ./apps/16/AdobePhotoshop.svg ./apps/16/AdobePrelude.svg ./apps/16/AdobePremierePro.svg ./apps/16/AdobeSpeedgrade.svg ./apps/16/AdobeUpdate.svg ./apps/16/AdobeWidgetBrowser.svg ./apps/16/AirPortUtility.svg ./apps/16/AlphaPlot.svg ./apps/16/Amazon-www.amazon.ca.svg ./apps/16/Amazon-www.amazon.cn.svg ./apps/16/Amazon-www.amazon.co.uk.svg ./apps/16/Amazon-www.amazon.com.svg ./apps/16/Amazon-www.amazon.de.svg ./apps/16/Amazon-www.amazon.es.svg ./apps/16/Amazon-www.amazon.fr.svg ./apps/16/Amazon-www.amazon.it.svg ./apps/16/AndYetItMoves.svg ./apps/16/accessibility/accessibility.svg ./apps/16/acetoneiso.svg ./apps/16/acidrip.svg ./apps/16/acorn.svg ./apps/16/actiona.svg ./apps/16/adventure-editor.svg ./apps/16/agave.svg ./apps/16/agenda.svg ./apps/16/aisleriot.svg ./apps/16/akonadi.svg ./apps/16/albert.svg ./apps/16/alevt.svg ./apps/16/alexandra.svg ./apps/16/alien-arena.svg ./apps/16/alienarena.svg ./apps/16/allen-b1.news.svg ./apps/16/altyo.svg ./apps/16/amazon-mp3-store-source.svg ./apps/16/amazonmp3.svg ./apps/16/amd-ati.svg ./apps/16/amsynth.svg ./apps/16/anaconda.svg ./apps/16/ancestris.svg ./apps/16/anki.svg ./apps/16/antimicro.svg ./apps/16/any_do.svg ./apps/16/application-x-miamplayer.svg ./apps/16/application-x-yarock.svg ./apps/16/applications-other.svg ./apps/16/applications-php.svg ./apps/16/aptdaemon-update-cache.svg ./apps/16/aptdaemon-upgrade.svg ./apps/16/aptik.svg ./apps/16/aptoncd.svg ./apps/16/apx.svg ./apps/16/aquemu.svg ./apps/16/areca.svg ./apps/16/argouml2.svg ./apps/16/ariamaestosa.svg ./apps/16/arkclient.svg ./apps/16/arronax.svg ./apps/16/arteFetcher.svg ./apps/16/artemanufrij.webpin.svg ./apps/16/arts.svg ./apps/16/as.svg ./apps/16/asbru-cm.svg ./apps/16/asc-de.svg ./apps/16/ascii-design.svg ./apps/16/ase.svg ./apps/16/aseprite.svg ./apps/16/assaultcube.svg ./apps/16/astah.svg ./apps/16/atelier.svg ./apps/16/athena.svg ./apps/16/atlauncher.svg ./apps/16/auale.svg ./apps/16/audio-recorder.svg ./apps/16/audiobook.svg ./apps/16/auralquiz.svg ./apps/16/autocad.svg ./apps/16/autokey.svg ./apps/16/avastgui.svg ./apps/16/avocode.svg ./apps/16/awn.svg ./apps/16/desktopconnected.svg ./apps/16/gnome-about-logo.svg ./apps/16/gnome-info.svg ./apps/16/gnome-logo-icon-transparent.svg ./apps/16/image-viewer/image-viewer.svg ./apps/16/info/applications-system-orange.svg ./apps/16/kmplot.svg ./apps/16/kstars.svg ./apps/16/media-player-banshee.svg ./apps/16/ms-powerpoint.svg ./apps/16/ms-word.svg ./apps/16/org.kde.kiten.svg ./apps/16/org.kde.kstars.svg ./apps/16/paint/paint.svg ./apps/16/panel/panel.svg ./apps/16/playstore.svg ./apps/16/plugin.svg ./apps/16/preferences-desktop-filetype-association.svg ./apps/16/preferences-desktop-theme.svg ./apps/16/smartphoneconnected.svg ./apps/16/star/star.svg ./apps/16/tablet/wacom.svg ./apps/16/xplayer.svg ./apps/scalable/AdobeAfterEffect.svg ./apps/scalable/AdobeAudition.svg ./apps/scalable/AdobeBridge.svg ./apps/scalable/AdobeDreamweaver.svg ./apps/scalable/AdobeEncore.svg ./apps/scalable/AdobeFirework.svg ./apps/scalable/AdobeFlashBuilder.svg ./apps/scalable/AdobeIllustrator.svg ./apps/scalable/AdobeIndesign.svg ./apps/scalable/AdobeLightroom.svg ./apps/scalable/AdobePhotoshop.svg ./apps/scalable/AdobePrelude.svg ./apps/scalable/AdobePremierePro.svg ./apps/scalable/AdobeSpeedgrade.svg ./apps/scalable/AdobeUpdate.svg ./apps/scalable/AlphaPlot.svg ./apps/scalable/Amazon-www.amazon.ca.svg ./apps/scalable/Amazon-www.amazon.cn.svg ./apps/scalable/Amazon-www.amazon.co.uk.svg ./apps/scalable/Amazon-www.amazon.com.svg ./apps/scalable/Amazon-www.amazon.de.svg ./apps/scalable/Amazon-www.amazon.es.svg ./apps/scalable/Amazon-www.amazon.fr.svg ./apps/scalable/Amazon-www.amazon.it.svg ./apps/scalable/AndYetItMoves.svg ./apps/scalable/accessibility/accessibility.svg ./apps/scalable/acetoneiso.svg ./apps/scalable/acidrip.svg ./apps/scalable/acorn.svg ./apps/scalable/actiona.svg ./apps/scalable/adventure-editor.svg ./apps/scalable/agave.svg ./apps/scalable/agenda.svg ./apps/scalable/aisleriot.svg ./apps/scalable/akonadi.svg ./apps/scalable/albert.svg ./apps/scalable/alevt.svg ./apps/scalable/alexandra.svg ./apps/scalable/alien-arena.svg ./apps/scalable/altyo.svg ./apps/scalable/amazon-mp3-store-source.svg ./apps/scalable/amd-ati.svg ./apps/scalable/amsynth.svg ./apps/scalable/anaconda.svg ./apps/scalable/anki.svg ./apps/scalable/antimicro.svg ./apps/scalable/any_do.svg ./apps/scalable/application-x-miamplayer.svg ./apps/scalable/applications-php.svg ./apps/scalable/aptik.svg ./apps/scalable/aptoncd.svg ./apps/scalable/apx.svg ./apps/scalable/aquemu.svg ./apps/scalable/areca.svg ./apps/scalable/argouml2.svg ./apps/scalable/ariamaestosa.svg ./apps/scalable/arkclient.svg ./apps/scalable/arronax.svg ./apps/scalable/arteFetcher.svg ./apps/scalable/artemanufrij.webpin.svg ./apps/scalable/arts.svg ./apps/scalable/as.svg ./apps/scalable/asbru-cm.svg ./apps/scalable/asc-de.svg ./apps/scalable/ascii-design.svg ./apps/scalable/ase.svg ./apps/scalable/aseprite.svg ./apps/scalable/assaultcube.svg ./apps/scalable/astah.svg ./apps/scalable/atelier.svg ./apps/scalable/athena.svg ./apps/scalable/atlauncher.svg ./apps/scalable/auale.svg ./apps/scalable/audio-recorder.svg ./apps/scalable/audiobook.svg ./apps/scalable/auralquiz.svg ./apps/scalable/autocad.svg ./apps/scalable/autokey.svg ./apps/scalable/avastgui.svg ./apps/scalable/avocode.svg ./apps/scalable/awn.svg ./apps/scalable/desktopconnected.svg ./apps/scalable/image-viewer/image-viewer.svg ./apps/scalable/info/applications-system-orange.svg ./apps/scalable/kstars.svg ./apps/scalable/media-player-banshee.svg ./apps/scalable/ms-powerpoint.svg ./apps/scalable/ms-word.svg ./apps/scalable/paint/paint.svg ./apps/scalable/panel/panel.svg ./apps/scalable/playstore.svg ./apps/scalable/preferences-desktop-filetype-association.svg ./apps/scalable/star/star.svg ./apps/scalable/tablet/wacom.svg ./apps/symbolic/AdobeAfterEffect-symbolic.svg ./apps/symbolic/AdobeAudition-symbolic.svg ./apps/symbolic/AdobeBridge-symbolic.svg ./apps/symbolic/AdobeDreamweaver-symbolic.svg ./apps/symbolic/AdobeEncore-symbolic.svg ./apps/symbolic/AdobeFirework-symbolic.svg ./apps/symbolic/AdobeFlashBuilder-symbolic.svg ./apps/symbolic/AdobeIllustrator-symbolic.svg ./apps/symbolic/AdobeIndesign-symbolic.svg ./apps/symbolic/AdobeLightroom-symbolic.svg ./apps/symbolic/AdobeMediaEncore-symbolic.svg ./apps/symbolic/AdobePhotoshop-symbolic.svg ./apps/symbolic/AdobePrelude-symbolic.svg ./apps/symbolic/AdobePremierePro-symbolic.svg ./apps/symbolic/AdobeSpeedgrade-symbolic.svg ./apps/symbolic/AdobeUpdate-symbolic.svg ./apps/symbolic/AdobeWidgetBrowser-symbolic.svg ./apps/symbolic/AirPortUtility-symbolic.svg ./apps/symbolic/AlphaPlot-symbolic.svg ./apps/symbolic/Amazon-www.amazon.ca-symbolic.svg ./apps/symbolic/Amazon-www.amazon.cn-symbolic.svg ./apps/symbolic/Amazon-www.amazon.co.uk-symbolic.svg ./apps/symbolic/Amazon-www.amazon.com-symbolic.svg ./apps/symbolic/Amazon-www.amazon.de-symbolic.svg ./apps/symbolic/Amazon-www.amazon.es-symbolic.svg ./apps/symbolic/Amazon-www.amazon.fr-symbolic.svg ./apps/symbolic/Amazon-www.amazon.it-symbolic.svg ./apps/symbolic/AndYetItMoves-symbolic.svg ./apps/symbolic/accessibility/accessibility-symbolic.svg ./apps/symbolic/acetoneiso-symbolic.svg ./apps/symbolic/acidrip-symbolic.svg ./apps/symbolic/acorn-symbolic.svg ./apps/symbolic/actiona-symbolic.svg ./apps/symbolic/adventure-editor-symbolic.svg ./apps/symbolic/agave-symbolic.svg ./apps/symbolic/agenda-symbolic.svg ./apps/symbolic/aisleriot-symbolic.svg ./apps/symbolic/akonadi-symbolic.svg ./apps/symbolic/albert-symbolic.svg ./apps/symbolic/alevt-symbolic.svg ./apps/symbolic/alexandra-symbolic.svg ./apps/symbolic/alien-arena-symbolic.svg ./apps/symbolic/alienarena-symbolic.svg ./apps/symbolic/allen-b1.news-symbolic.news.svg ./apps/symbolic/altyo-symbolic.svg ./apps/symbolic/amazon-mp3-store-source-symbolic.svg ./apps/symbolic/amazonmp3-symbolic.svg ./apps/symbolic/amd-ati-symbolic.svg ./apps/symbolic/amsynth-symbolic.svg ./apps/symbolic/anaconda-symbolic.svg ./apps/symbolic/ancestris-symbolic.svg ./apps/symbolic/anki-symbolic.svg ./apps/symbolic/antimicro-symbolic.svg ./apps/symbolic/any_do-symbolic.svg ./apps/symbolic/application-x-miamplayer-symbolic.svg ./apps/symbolic/application-x-yarock-symbolic.svg ./apps/symbolic/applications-other-symbolic.svg ./apps/symbolic/applications-php-symbolic.svg ./apps/symbolic/aptdaemon-update-cache-symbolic.svg ./apps/symbolic/aptdaemon-upgrade-symbolic.svg ./apps/symbolic/aptik-symbolic.svg ./apps/symbolic/aptoncd-symbolic.svg ./apps/symbolic/apx-symbolic.svg ./apps/symbolic/aquemu-symbolic.svg ./apps/symbolic/areca-symbolic.svg ./apps/symbolic/argouml2-symbolic.svg ./apps/symbolic/ariamaestosa-symbolic.svg ./apps/symbolic/arkclient-symbolic.svg ./apps/symbolic/arronax-symbolic.svg ./apps/symbolic/arteFetcher-symbolic.svg ./apps/symbolic/artemanufrij.webpin-symbolic.svg ./apps/symbolic/arts-symbolic.svg ./apps/symbolic/as-symbolic.svg ./apps/symbolic/asbru-cm-symbolic.svg ./apps/symbolic/asc-de-symbolic.svg ./apps/symbolic/ascii-design-symbolic.svg ./apps/symbolic/ase-symbolic.svg ./apps/symbolic/aseprite-symbolic.svg ./apps/symbolic/assaultcube-symbolic.svg ./apps/symbolic/astah-symbolic.svg ./apps/symbolic/atelier-symbolic.svg ./apps/symbolic/athena-symbolic.svg ./apps/symbolic/atlauncher-symbolic.svg ./apps/symbolic/auale-symbolic.svg ./apps/symbolic/audio-recorder-symbolic.svg ./apps/symbolic/audiobook-symbolic.svg ./apps/symbolic/auralquiz-symbolic.svg ./apps/symbolic/autocad-symbolic.svg ./apps/symbolic/autokey-symbolic.svg ./apps/symbolic/avastgui-symbolic.svg ./apps/symbolic/avocode-symbolic.svg ./apps/symbolic/awn-symbolic.svg ./apps/symbolic/desktopconnected-symbolic.svg ./apps/symbolic/gnome-about-logo-symbolic.svg ./apps/symbolic/gnome-info-symbolic.svg ./apps/symbolic/gnome-logo-icon-transparent-symbolic.svg ./apps/symbolic/image-viewer/image-viewer-symbolic.svg ./apps/symbolic/info/applications-system-orange-symbolic.svg ./apps/symbolic/kmplot-symbolic.svg ./apps/symbolic/kstars-symbolic.svg ./apps/symbolic/media-player-banshee-symbolic.svg ./apps/symbolic/ms-powerpoint-symbolic.svg ./apps/symbolic/ms-word-symbolic.svg ./apps/symbolic/org.kde.kiten-symbolic.svg ./apps/symbolic/org.kde.kstars-symbolic.svg ./apps/symbolic/paint/paint-symbolic.svg ./apps/symbolic/panel/panel-symbolic.svg ./apps/symbolic/playstore-symbolic.svg ./apps/symbolic/plugin-symbolic.svg ./apps/symbolic/preferences-desktop-filetype-association-symbolic.svg ./apps/symbolic/preferences-desktop-theme-symbolic.svg ./apps/symbolic/smartphoneconnected-symbolic.svg ./apps/symbolic/star/star-symbolic.svg ./apps/symbolic/tablet/wacom-symbolic.svg ./apps/symbolic/xplayer-symbolic.svg ./devices/16/bluetooth.svg ./devices/scalable/bluetooth.svg ./devices/symbolic/bluetooth-symbolic.svg ./mimetypes/16/application-mspowerpoint.svg ./mimetypes/16/wps-office-doc.svg ./mimetypes/16/wps-office-ppt.svg ./mimetypes/scalable/application-java.svg ./mimetypes/scalable/application-mspowerpoint.svg ./mimetypes/scalable/wps-office-doc.svg ./places/16/user-trash.svg ./places/16/folder-templates.svg ./places/symbolic/folder-templates-symbolic.svg ./scalable-max-32/status/process-working-symbolic.svg ./status/16/desktopconnected.svg ./status/16/desktoptrusted.svg ./status/16/network-wired-offline.svg ./status/16/org.gnome.Shell.Extensions.GSConnect.svg ./status/16/security-medium.svg ./status/16/smartphoneconnected.svg ./status/16/smartphonetrusted.svg ./status/16/sms-send.svg ./status/symbolic/desktopconnected-symbolic.svg ./status/symbolic/desktoptrusted-symbolic.svg ./status/symbolic/network-wired-offline-symbolic.svg ./status/symbolic/org.gnome.Shell.Extensions.GSConnect-symbolic.gnome.Shell.Extensions.GSConnect.svg ./status/symbolic/security-medium-symbolic.svg ./status/symbolic/smartphoneconnected-symbolic.svg ./status/symbolic/smartphonetrusted-symbolic.svg ./status/symbolic/sms-send-symbolic.svg ./AUTHORS ./CREDITS ./templates/Suru Palette.gvswatch ```
gusbemacbe commented 5 years ago

Hi @SmartFinn

List of icons with renderer issues

I tried yo understand. Do you suggest me to remove them?

List of icons with bitmap images

The icons Abricotine and Keopatra use the tiled bkacground which is a bitmap, bu I do not know how to convert tiled background into vector at Inkscape.

Kaffeine is a symlink to Caffeine. I will fix Caffeine.

List of broken symlinks

Thank you, I merged your PR.

List of files with invalid filenames

In a desktop configuration file of Screenshot, in Manjaro GNOME, there is Icon[ar]=ذخیرهٔ عکس‌صفحه. Should I remove it?

List of files with executable bit

In the future, how to prevent that the icons become executable bits?

SmartFinn commented 5 years ago

@gusbemacbe

I tried yo understand. Do you suggest me to remove them?

Of course no. In this issue PapirusDevelopmentTeam/papirus-icon-theme#404 we faced with the same bug too. I fix it by converting cleaned SVG file to plain SVG with Inkscape CLI and then cleaned by SVGO with correct config.

# Ex.
inkscape --vacuum-defs -z ./actions/16/bookmark-remove.svg --export-plain-svg=./actions/16/bookmark-remove.svg
svgo --config=tools/_svgo.yml ./actions/16/bookmark-remove.svg

The icons Abricotine and Keopatra use the tiled bkacground which is a bitmap, bu I do not know how to convert tiled background into vector at Inkscape.

This is sad. So, left these icons as is.

In a desktop configuration file of Screenshot, in Manjaro GNOME, there is Icon[ar]=ذخیرهٔ عکس‌صفحه. Should I remove it?

I do not sure that the Icon[ar]=ذخیرهٔ عکس‌صفحه works. Do you test it? Anyway, that is a bug in the desktop-file, the developers should use icon named as appname-ar instead of the current filename because it breaks the icon theme.

In the future, how to prevent that the icons become executable bits?

There are three ways:

gusbemacbe commented 5 years ago

Of course no. In this issue PapirusDevelopmentTeam/papirus-icon-theme#404 we faced with the same bug too. I fix it by converting cleaned SVG file to plain SVG with Inkscape CLI and then cleaned by SVGO with correct config.

I also think that it affects scalable icons in KDE. If you have KDE machine virtual, please check the icons in the application menu and application dashboard.

The icons of Emacs, Insync, Octopi and other got missed in KDE. Do you think it is SVG bug? I tried all the ways to fix it, but it was unsuccessful.

I do not sure that the Icon[ar]=ذخیرهٔ عکس‌صفحه works. Do you test it? Anyway, that is a bug in the desktop-file, the developers should use icon named as appname-ar instead of the current filename because it breaks the icon theme.

I have to switch the language of Manjaro GNOME to Arabic and will test it.

SmartFinn commented 5 years ago

@gusbemacbe

This is a quote from freedesktop Icon Naming Guidelines:

Icon names are in the en_US.US_ASCII locale. This means that the allowable characters in the icon names, must fall withing the US-ASCII character set. As a further restriction, all icon names may only contain lowercase letters, numbers, underscore, dash, or period characters. Spaces, colons, slashes, and backslashes are not allowed. Also, icon names must be spelled as they are in the en_US dictionary.

https://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html#guidelines

So, using non-latin charsets in the Icon entry is a bug.

gusbemacbe commented 5 years ago

Thank you, I will remove these bugs and report it to creators of Screenshot at Manjaro GNOME.

gusbemacbe commented 5 years ago

After removing these icons, GitKraken is forcing to stage all modified icons:

image

I have to create the new branch and will stage everything so that you can analyse if it is all OK

gusbemacbe commented 5 years ago

Ready. Here is the branch beta-emergence.

gusbemacbe commented 5 years ago

It seems that I forgot of adding the git-hook, it is why GitKraken was reverting the icons to the previous version of executable-bitted icons. Is it exactly?

gusbemacbe commented 5 years ago

In the branch beta-emergence, I discovered that almost 70 icons are broken thanks to the damned app Tower which damaged. I replaced Tower for GitKraken.

gusbemacbe commented 5 years ago

I have removed the Arabic icons names from the branch beta, GitKraken have not modified or broken more than 70 icons or forced the icons to be staged. It has worked.

I think I have understood what happened with the executable bit, it was Tower which has caused it. I will avoid Tower.

gusbemacbe commented 5 years ago

I have another doubt. Se two screenshots:

  1. Notice the icons Agave, Bluefish and Brave.

bug1

  1. The icons Insync and Vivaldi

bug2

Is it renderer bug? Everything works well in GNOME and non-KDE environments, but some are not well rendered in KDE.

Does the Inkscape SVGO CLI solve it?

gusbemacbe commented 5 years ago

I found the issues related to it:

https://forum.kde.org/viewtopic.php?t=121637

I have no idea of how solving this bug.

SmartFinn commented 5 years ago

@gusbemacbe

Does the Inkscape SVGO Cli solve it?

You should try. SVG code of most Gravit Designer's icons looks ugly for me. Seems Gravit Designer store their metadata in SVG files. If the metadata are useful I recommend to you store the SVG files in src directory. In the theme, all SVG should be plain and clean, without any non-standard elements and attributes.

gusbemacbe commented 5 years ago

I have read https://github.com/keeferrourke/la-capitaine-icon-theme/issues/294, I have to rewrite pure and advanced SVG codes. I have to use polygon and rect instead as @Riotism has replaced paths.

gusbemacbe commented 5 years ago

In the theme, all SVG should be plain and clean, without any non-standard elements and attributes.

Too bad, I have to redesign more than 1,3k (I am referring to colourful icons), cleaning and paining them. Does Inkscape use SVG standard elements?

SmartFinn commented 5 years ago

Too bad, I have to redesign more than 1,3k (I am referring to colourful icons), cleaning and paining them.

That can be made by a script.

Does Inkscape use SVG standard elements?

Inkscape store metadata in SVG files too, but make it in the better way than Gravit Designer. We delete the metadata with SVGO.

gusbemacbe commented 5 years ago

Tonight I will look at the Gravit-based SVG files if the codes are similar and if the same codes can be rewritten.

gusbemacbe commented 5 years ago

I used Figma to clean the codes of Brave icon, reducing 58K to 5.8K, but it is not rendered well in KDE, I applied rect or polygon to it and it did not work well.

I open it with Inkscape and saved as Plain SVG, and it did not work either. I also exported as optimised SVG and it did not work another time.

But you can analyse four versions of Brave icons that I send as compressed archive to you:

Compare.tar.gz

SmartFinn commented 5 years ago

@gusbemacbe I didn't see any issue on Kubuntu 18.04. Do you test it in Manjaro?

screenshot from 2018-09-24 14-16-59

screenshot from 2018-09-24 14-14-33

image

SmartFinn commented 5 years ago

@gusbemacbe but I've the issue too with the brave icon from beta brach:

image

image

gusbemacbe commented 5 years ago

Yes, two causes:

  1. it must be because Manjaro uses KDE Plasma 5.13.5 and KDE Framework 5.50 and QT 5.11.2.
  2. it must be index.theme bug

I will upload the icon of Brave Optimised to the beta branch for you to test if it is still the same issue, if still the same issue, then it can be index.theme bug.

gusbemacbe commented 5 years ago

I found two errors and fixed them, but these two errors did not solve the rendering bug.

SmartFinn commented 5 years ago

@gusbemacbe

I will upload the icon of Brave Optimised to the beta branch for you to test if it is still the same issue, if still the same issue, then it can be index.theme bug.

Yes, the rendering issue still there. I don't think that is a bug in index.theme, because the icon isn't from apps/16 or apps/symbolic.

gusbemacbe commented 5 years ago

Do you mean that the Brave icon is rendered from monochromatic icon of folders 16 or symbolic instead of coloured icon?

SmartFinn commented 5 years ago

@gusbemacbe no, that icon is NOT 16px or symbolic icons because has differ color #FFFFF7 instead of #808080. I tried to replace brave icon to Papirus one, but no luck, the icon not shown.

gusbemacbe commented 5 years ago

Wait, I have an idea

gusbemacbe commented 5 years ago

No luck, I resized to 1024px and the rendering is not improved yet. I remembered that Octopi and Emacs had that issue and expanded to 1024px and they worked.

I have always to investigate the origin of this cause.

gusbemacbe commented 5 years ago

@ChrisP4, are you an user of KDE? Can you discover what caused this bug in these icons?

gusbemacbe commented 5 years ago

I came to know that exporting to SVG will be no longer free in the future versions of Gravit Designer, I will migrate to Inkscape (honestly I find it too difficult) or Karbon (I know it is discontinued). Poor of me, I will have to redesign every icon in the whole icons theme.

gusbemacbe commented 5 years ago

@SmartFinn

I have released the Release Candidate 1 in the unstable branch:

I will readjust Abricotine and Kleopatra icons and will add to the Release Candidate 2.

gusbemacbe commented 5 years ago

@SmartFinn

I have just released the version Release Candidate 2, readjusting the icons Abricotine and Kleopatra, with the removal of bitmap and replacement for the vectorised and compounded paths.

Please, test the icons theme. Can you check if there are executable bits please?

SmartFinn commented 5 years ago

@gusbemacbe

Can you check if there are executable bits please?

All is fine. You can check it by running find . -type f -executable command in your project directory.

Please, test the icons theme.

I'll test it a bit later.

gusbemacbe commented 5 years ago

Sorry, I have released the Release Candidate 3, if you strange the difference, I am referring to the highlight effect, I will eplain:

Noitce how the highlight effect looked ugly in the top of icons in KDE:

ugly highlight

I did a mistake for not having vectorised the border, so I had to redesign every icon, principally those only that the KDE users use more daily. I have readjusted the highlight effect, vectorising the border and here is how the highlight effect has improved:

beautiful highlight

gusbemacbe commented 5 years ago

Unfortunately in spite of the success, Brave and Emacs icons do not have Gravit Designer metadata, but are still facing rendering issues. Better to call a KDE designer to analyse them. Before they appeared to be normal and functional, but after days, they appear to be broken.

saligari commented 5 years ago

@gusbemacbe Yes I'm a KDE user. I've been really busy with school and hadn't seen this. As far as I can tell you found at least part of the solution? I'll read this thread sometime this week and look into it.

gusbemacbe commented 5 years ago

Hi @ChrisP4!

Yes, please, use the unstable branch and analyse the icons of Brave and Emacs.

saligari commented 5 years ago

Hey, @gusbemacbe :)

I'm not quite sure what you mean by analyse, but both Brave and Emacs icons from the unstable branch look fine to me on KDE: screenshot_20181007_215436

and highlighting works as expected

gusbemacbe commented 5 years ago

Hi @ChrisP4 , I am not speaking of highlighting, but of broken icons of Brave and Emacs. When I run Manjaro KDE on my external HD, I will show you.

Experiment using Application Dashboard.

saligari commented 5 years ago

hello @gusbemacbe I'm using KDE Neon (18.04) right now, and everything seems ok: screenshot_20181008_161412

I'm not using emacs or brave so I just set those icons for different programs. That shouldn't matter though.

gusbemacbe commented 5 years ago

Thank you all, @ChrisP4 and @SmartFinn ! It is well rendered in your KDE, but it is not well rendered only in Manjaro KDE. I will report to Manjaro developers.