search

gusbemacbe / suru-plus

Suru++ 25 — A cyberpunk, elegant, futuristic and Papirus-like third-party icons theme
GNU General Public License v3.0
344 stars 32 forks source link

[Request] dark variant icon #4

Closed denikris closed 6 years ago

denikris commented 6 years ago

this is inkscape in lubuntu 18.04 i386 using adapta-nokto-eta 2018-05-10-212414_1024x600_scrot

hope you can make white for icons in dark theme and colorful icon in panel whether its dark/light

gusbemacbe commented 6 years ago

Suru++ is for light environment. We must create a new theme repository for dark environment.

As for for colourful icons of apps, we need to know your icon size in this panel.

gusbemacbe commented 6 years ago

While you do not provide the icon size in this panel, we can't provide. We are waiting for your answer.

Bonandry commented 6 years ago

it's a very complicated job, I have to change every icon by hand ... I do not know if I can do it

Bonandry commented 6 years ago

schermata da 2018-05-10 20-50-04

gusbemacbe commented 6 years ago

@Magog64, let me work and prepare for you today. Ok? Sorry for my absence. I was sleeping.

gusbemacbe commented 6 years ago

@Magog64, you do not need to change every icon. Only the grey icons. I analysed your dark theme. I am going to fix your theme.

gusbemacbe commented 6 years ago

We started the new repository https://github.com/gusbemacbe/SURU-PLUS-DARK, but I will transfer ownership to Andrea and I will be a collaborator.

Remember that this repository is alpha. Do not download now!

denikris commented 6 years ago

@gusbemacbe @Magog64 thanks for respond, my panel in the screenshot is 28px, and the icon in icon-tasklists maybe 26px as user change panel size, the icon following with it size smaller 2px, both adapta dark/light theme using dark panel as default

gusbemacbe commented 6 years ago

Hello @denikris

Therefore, all folders 24, 28 and 32 are grey icons. And the folder apps/24 are grey. Can you resize the panel to 33px and see if they turn colourful?

  1. Fork our repository
  2. Go to the folder desktop
  3. Create a new folder and name it as "lubuntu"
  4. Go to /usr/share/applications and select, drag all desktop files which only have missed icons and drop into the folder lubuntu.
  5. Make a pull request that we will merge and analyse the desktop files.
Bonandry commented 6 years ago

hello, I'm back from work now, I calmly read the messages

2018-05-11 13:53 GMT+02:00 Gustavo Reis notifications@github.com:

Hello @denikris https://github.com/denikris

Therefore, all folders 24, 28 and 32 are grey icons. And the folder apps/24 are grey. Can you resize the panel to 33px and see if they turn colourful?

  1. Fork our repository
  2. Go to the folder desktop
  3. Create a new folder and name it as "lubuntu"
  4. Go to /usr/share/applications and select, drag all desktop files which only have missed icons and drop into the folder lubuntu.
  5. Make a pull request that we will merge and analyse the desktop files.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Magog64/SURU-PLUS/issues/4#issuecomment-388342212, or mute the thread https://github.com/notifications/unsubscribe-auth/AHlswQvy3Z-KF5bskYjeP8UXOte1MC4rks5txXujgaJpZM4T5_G7 .

-- Andrea

denikris commented 6 years ago

2018-05-12-095045_1024x600_scrot this is panel with size 40px

denikris commented 6 years ago

2018-05-12-095647_1024x600_scrot

i think the problem is from the panel which is have its max size of icon-tasklist depends on panel size

gusbemacbe commented 6 years ago

What is your environment ? Gnome or KDE? I will install a virtual machine of Lubuntu for analysing the problem of icon size.

Bonandry commented 6 years ago

gnome with ubuntu 18.04

2018-05-12 5:24 GMT+02:00 Gustavo Reis notifications@github.com:

What is your environment ? Gnome or KDE? I will install a virtual machine of Lubuntu for analysing the problem of icon size.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Magog64/SURU-PLUS/issues/4#issuecomment-388526407, or mute the thread https://github.com/notifications/unsubscribe-auth/AHlsweQYecLQWptC8nSz1VYS73rFkJvIks5txlXSgaJpZM4T5_G7 .

-- Andrea

gusbemacbe commented 6 years ago

@Magog64, I did a search, I saw Lubuntu uses only LXDE or KDE. It doesn't use Gnome.

gusbemacbe commented 6 years ago

@denikris

Today I analysed Lubuntu, when I changed to 23 and to 26, they turned colourful, but in 24px, they turned grey. You can see the GIF:

2018-05-12 17 18 49

I will readjust the index.html and test it.

gusbemacbe commented 6 years ago

I tested it and it worked now. The bug is gone. I will update the repository.

2018-05-12 17 42 03

gusbemacbe commented 6 years ago

@denikris

It is updated. Update the Suru++ icon pack and move the folder Suru++ Lubuntu oustide of Suru++ to the same folder icon. Apply "Suru++ Lubuntu".

As the bug is solved, we close the issue.

gusbemacbe commented 5 years ago

Hi @denikris !

I inform you that Suru++ Dark has been upgraded and renamed to Suru++ 25 Dark. Check the screenshots: https://www.opendesktop.org/p/1245808/.