search

gusbemacbe / suru-plus

Suru++ 25 — A cyberpunk, elegant, futuristic and Papirus-like third-party icons theme
GNU General Public License v3.0
344 stars 32 forks source link

Icon for VMWare Horizon Client #41

Closed bridnour closed 5 years ago

bridnour commented 5 years ago

Is it possible to make a suru++ version of the "VMWare Horizon Client" Icon.

This is it's .desktop entry: [Desktop Entry] Encoding=UTF-8 Type=Application Icon=vmware-view.png Exec=vmware-view %u MimeType=x-scheme-handler/vmware-view Categories=Application;Network; Name=VMware Horizon Client

This is the default icon: vmware-view

gusbemacbe commented 5 years ago

Hi @bridnour !

It is hard-coded because of extension .png. You need to remove .png.

It is added to the tasks at the Project. I will add this icon to the unstable branch.

bridnour commented 5 years ago

Thanks!

I'll be sure to remove the .png in the desktop entry.

SmartFinn commented 5 years ago

@gusbemacbe a small note, these file extension png, svg, and xpm do not make icon hardcoded. Icon lookup function removes the extensions wherever I tested it. Do you know a framework/distro where is not worked?

gusbemacbe commented 5 years ago

@SmartFinn

In Deepin OS and in Manjaro.

In my Manjaro now, I have just tested the desktop files, adding the extension, strange, it works. I do not understand. Before, one of desktop files had that extension and it did not appear having an correct icon applied by the icons theme. Maybe it must be Deepin OS. I stopped using Deepin OS some months ago due to the bug of keyboard.

gusbemacbe commented 5 years ago

Under Manjaro, I have applied your icons theme Papirus, tested another time, it still works.

It must be Deepin OS. But if I remember correctly, some Flatpak-built and snap-built apps used the extension and did not appear having correct icon applied by the icons theme.

I have LIbreOffice and other installed via flatpak now and let me test, using your icons theme.

gusbemacbe commented 5 years ago

I modifed the desktop files of a Flatpak-built-built app under Manjaro, it works. Then it must be Deepin OS.

SmartFinn commented 5 years ago

@gusbemacbe in Deepin 15.6 it works too.

After added .png to Icon value, the icon applied:

image

gusbemacbe commented 5 years ago

Then it means it can be because of Gravit metadata with base64 which prevents the icon of being applied or because I had multiple environments in the same desktop.

gusbemacbe commented 5 years ago

Hi @bridnour!

The icon has been added to the unstable branch. It will be merged into the master branch tomorrow.