Closed aburke161 closed 5 years ago
gusbemacbe
commented
5 years ago Hi @aburke161 !
It is one of the known issues by me.
As I am done with the college and got graduated, I will begin to review the Suru++ 20 and upgrade the new version, papirusise the icons to end up with all the bugs.
aburke161
commented
5 years ago Hey @gusbemacbe (:
Ah okay, that's good to know. I was worried it was something specific to my system since I couldn't find anyone talking about it. Congratulations on graduating! This is a gorgeous theme, by the way.
gusbemacbe
commented
5 years ago Thank you, @aburke161 ! Observe that I use KDE as the main OS for testing SVG icons if they look good, but I was unaware that the original trash icon was not fixed. I had acknowledge of this icon. The original author of Suru++ uses GTK as the main OS and did not test the icons in KDE or can not test because he is not a system analysist or programmer, so I assume his place. I am co-creator and contributor of his original icons theme Suru++, which does not support KDE.
gusbemacbe
commented
5 years ago @aburke161 !
It has been fixed and mdoernised in the commit 53c8d53635653fab65401e90f07503162586b76b, and see the preview in KDE:
gusbemacbe
commented
5 years ago @aburke161
Ready, official and released!
aburke161
commented
5 years ago @gusbemacbe
Fantastic! Just tested on my system and can confirm it looks great. Thank you!
The "edittrash.svg" icon doesn't render correctly in KDE Plasma 5.14. It seems that the clipping is being ignored? The paper inside of the bin is rendered on the top layer. I'm not sure if this is a problem with the theme or how Plasma itself renders svg files. However, it renders correctly in Firefox as well as Inkscape so I figure this is a good place to start. Attached is a screenshot of how it is rendered.