Closed SmartFinn closed 5 years ago
@gusbemacbe do you want to connect the repo to Travis CI for automated testing?
Hi @SmartFinn
Strange, some of these files are purely SVG, I will check these files. If it insists, I will disconsider Gravit Designer and will switch to other alternative.
Yes, please, do it.
I have discovered the real cause.
Gravit Designer is very ridiculous software because it converted pure vector paths/shapes into base64. I might be wrong, but I made a simple vector and it converted into base64!
I will use Inkscape instead, although I do not like Inkscape.
Wow, Inkscape does not convert those shapes into base64!
Ready, @SmartFinn !
Travis CLI approved.
@gusbemacbe Hey, I found another bug that prevents to adapt this icon theme for Oomox. It is the different color notation in the places. They are should be hex pair in lowercase (#ffffff
instead of #FFF
). I'll fix it, but I have one question. Is the color of symbol on folder-activities.svg
icon bug or not? It looks strange.
Ah, a bug, it was my fail, because I put the uppercase hexadecimal code in the repo suru-plus-folders
.
@gusbemacbe ok. I'll fix it.
@gusbemacbe it may be to change the symbol color from #ffffff
to #fefefe
to avoid conflict with gradients and highlight?
@gusbemacbe also will be great to replace opacity .62
to hex color, that allows to use any symbols color instead of white or black.
Yes, @SmartFinn , the symbols should be #fefefe
because all gradients and highlights are white and opaque.
Yes, all symbols are 62% opaque. Gravit Designer does not use the hexadecimal code with opacity like Inkscape does.
It is important that in the yellow colour, the symbols must be black because white on yellow are too illegible to understand.
Yes, all symbols are 62% opaque. Gravit Designer does not use the hexadecimal code with opacity like Inkscape does.
You have to choose:
style="opacity:.62;fill:#ffffff;
to style="fill:#b8dff6"
) and allow Oomox to change the colorI choose the item 2. But I do not know to replace and convert into "HEXA" (hexadecimal with alpha).
I have a doubt. Can it affect the suru-plus-folders
as it will use "HEXA"?
But I do not know to replace and convert into "HEXA" (hexadecimal with alpha).
There is no alpha channel, it's a simple hex code.
Can it affect the
suru-plus-folders
as it will use "HEXA"?
No, suru-plus-folders doesn't work with colors, it works with symlinks.
@gusbemacbe a lot of icons use RGB color code:
$ > grep -lr 'rgb(' Suru++/ | wc -l
2429
$ >
Can you fix it?
Most of those icons can be fixed by the command:
find . -type f -exec sed -i -e 's/rgb(255,255,255)/#ffffff/g' -e 's/rgb(0,0,0)/#000000/g' '{}' +
You can leave apps/64 as is. Only monochrome icons should be fixed.
Yes, I can. Gravit Designer uses heavily the RGB, it is why I will replace for vector editor.
Ready.
That's not all. Run grep -lr 'rgb(' Suru++/
to get the list of files that affected.
Maybe because of the folder 64
, you forgot of putting 16
: grep -lr 'rgb(' Suru++/16/
.
OK, I will correct now.
Ready, @SmartFinn .
Observe that the folder 16
of intl
is symlinked to 64
which is a colorful scalable.
I would like to redesign all devices and mimetypes icons (only the folders 64
). Do I must wait?
Successful, using find
, grep and
sed, I replaced all RGB for HEX of all the files in the folder
apps/64`, so it will facilitate my replacement of all colours for other colours of Telinkrin and Arrongrin.
make -i test
shows the following issues:List of icons with embeded bitmap images
List of broken symlinks