session icons are missing

gusbemacbe / suru-plus

Suru++ 25 — A cyberpunk, elegant, futuristic and Papirus-like third-party icons theme

GNU General Public License v3.0

337 stars 32 forks source link

session icons are missing #86

Closed materemias closed 5 years ago

materemias commented 5 years ago

I have tried v25 from aur and running the provided install.sh as well and shutdown and edit buttons are missing (transparency is just because panel lost focus when I made the screenshot). Gnome shell 3.30.2

gusbemacbe commented 5 years ago

What distribution, @materemias ?

materemias commented 5 years ago

Arch. Installed Suru from AUR

gusbemacbe commented 5 years ago

I have Arch Linux virtual machine. I may analyse in the afternoon.

materemias commented 5 years ago

Thanks. I could reproduce this on my other PC.

gusbemacbe commented 5 years ago

Still the same issue?

materemias commented 5 years ago

yes, and i also got this with flameshot's icon and of the originally reported problem:

SmartFinn commented 5 years ago

@gusbemacbe the following symbolic icons are broken:

[x] apps/symbolic/security-high-symbolic.svg
[x] apps/symbolic/security-low-symbolic.svg
[x] apps/symbolic/qtractor-symbolic.svg
[x] apps/symbolic/system-lock-screen-symbolic.svg
[x] apps/symbolic/system-log-out-symbolic.svg
[x] apps/symbolic/system-reboot-symbolic.svg
[x] apps/symbolic/system-shutdown-symbolic.svg
[x] apps/symbolic/system-suspend-hibernate-symbolic.svg
[x] apps/symbolic/system-suspend-symbolic.svg
[x] apps/symbolic/system-switch-user-symbolic.svg
[x] places/symbolic/network-workgroup-symbolic.svg

security-high-symbolic and security-high-symbolic is okay, but they colored.

materemias commented 5 years ago

seems to be not the case on my machine

SmartFinn commented 5 years ago

@gusbemacbe you have to be attentive when coping colored icons to symbolic.

For exapmle those icons are useless:

places/symbolic/bookmark-missing-symbolic.svg
places/symbolic/bookmarks-symbolic.svg
places/symbolic/folder-black-symbolic.svg
places/symbolic/folder-blue-symbolic.svg
places/symbolic/folder-bluegrey-symbolic.svg
places/symbolic/folder-brown-symbolic.svg
places/symbolic/folder-custom-symbolic.svg
places/symbolic/folder-cyan-symbolic.svg
places/symbolic/folder-green-symbolic.svg
places/symbolic/folder-grey-symbolic.svg
places/symbolic/folder-magenta-symbolic.svg
places/symbolic/folder-mint-symbolic.svg
places/symbolic/folder-orange-symbolic.svg
places/symbolic/folder-red-symbolic.svg
places/symbolic/folder-teal-symbolic.svg
places/symbolic/folder-violet-symbolic.svg
places/symbolic/folder-yellow-symbolic.svg

gusbemacbe commented 5 years ago

Do all these icons in the folders symbolic need to be monochromatic (white or black)?

SmartFinn commented 5 years ago

@gusbemacbe

Do all these icons in the folders symbolic need to be monochromatic (white or black)?

Not only. GTK3 replaces a color of all paths for *-symbolic icons to another. If you open apps/symbolic/system-shutdown-symbolic.svg in Inkscape, select all paths and then change their color to #D8DEE9 you'll see the same that displayed on the screenshots.

gusbemacbe commented 5 years ago

@SmartFinn, ready. Now did it improve?

@materemias, see if the update solved it. (instead of AUR, use install.sh). Soon I will update the AUR.

SmartFinn commented 5 years ago

@gusbemacbe almost. I notice that you using ellipse in places/16/network-workgroup.svg icon, but only paths are allowed in symbolic icons.

gusbemacbe commented 5 years ago

@SmartFinn, ready, I have replaced ellipses for paths. The next time, I will convert everything to paths in the symbolic folders.

materemias commented 5 years ago

yeah it did, thanks!

gusbemacbe commented 5 years ago

Great, @materemias ! I inform Suru++ is officially compatible with Oomox, then you can change any colour of the small icons and of the folders you want!