search

gushphp / ToInlineStyleEmailBundle

A Symfony2 bundle to use the CssToInlineStyles converter by Tijs Verkoyen
MIT License
59 stars 34 forks source link

Fix unused webroot #11

Closed Richtermeister closed 9 years ago

Richtermeister commented 9 years ago

The webRoot parameters was not used during css path resolution. This assumed that the cache was built via front controller and the current directory is the webroot, which is not the case when the cache is built from cli. This causes the following error:

PHP Warning:  file_get_contents(style/email.css): failed to open stream: No such file or directory in /var/www/vendor/robertotru/to-inline-style-email-bundle/RobertoTru/ToInlineStyleEmailBundle/Twig/InlineCssNode.php on line 26

and the styles to not be included. This PR fixes this situation and also cleans up incorrect phpdocs and unused includes.

Richtermeister commented 9 years ago

@robertotru Let me know if I can do anything to facilitate merging this. Thank you for your time.

robertotru commented 9 years ago

Sorry. I accidentally turned off the notifications on GitHub. I added you as part of the bundle collaborators. Kind regards RT Il 11/Dic/2014 03:04 "Daniel Richter" notifications@github.com ha scritto:

@robertotru https://github.com/robertotru Let me know if I can do anything to facilitate merging this. Thank you for your time.

— Reply to this email directly or view it on GitHub https://github.com/robertotru/ToInlineStyleEmailBundle/pull/11#issuecomment-66558483 .

Richtermeister commented 9 years ago

Hey Robert,

awesome, thank you. If it's ok with you I'd like to add phpSpec coverage to the project, so we have a test base for future contributions. Thanks again, have a great day!

robertotru commented 9 years ago

I do agree. Thanks a lot.

RT Il 11/Dic/2014 21:40 "Daniel Richter" notifications@github.com ha scritto:

Hey Robert,

awesome, thank you. If it's ok with you I'd like to add phpSpec coverage to the project, so we have a test base for future contributions. Thanks again, have a great day!

— Reply to this email directly or view it on GitHub https://github.com/robertotru/ToInlineStyleEmailBundle/pull/11#issuecomment-66684873 .

robertotru commented 9 years ago

Hi Daniel,

What do you think about the proosal by Luis Cordova?

Kind regards, Roberto

@robertotru https://github.com/robertotru Let me know if I can do anything to facilitate merging this. Thank you for your time.

— Reply to this email directly or view it on GitHub https://github.com/robertotru/ToInlineStyleEmailBundle/pull/11#issuecomment-66558483 .

Richtermeister commented 9 years ago

Hey Roberto,

I actually work with Luis, and I can tell you that he is a good overall influence on projects such as this and loves best practices. If you're short on time I can work with him to apply his suggestions to this project.

robertotru commented 9 years ago

Ok. I am incredibly busy with my newborn and my new job so that I have no time to do any extra job. Thank you so much R Il 05/Gen/2015 22:35 "Daniel Richter" notifications@github.com ha scritto:

Hey Roberto,

I actually work with Luis, and I can tell you that he is a good overall influence on projects such as this and loves best practices. If you're short on time I can work with him to apply his suggestions to this project.

— Reply to this email directly or view it on GitHub https://github.com/robertotru/ToInlineStyleEmailBundle/pull/11#issuecomment-68786005 .

Richtermeister commented 9 years ago

Well duuude, congratulations!! That is great!

robertotru commented 9 years ago

Being a father is a full time stressful job with some joy but several drawbacks. And hey, I'm not paid! 😂

The payd job is for Zalando in Berlin. Great company, with cool and nice people from everywhere (USA, Brasil, China, Australia, Portugal, Russia, etc). Great city. Great experience.

Regards Roberto Il 05/Gen/2015 23:37 "Daniel Richter" notifications@github.com ha scritto:

Well duuude, congratulations!! That is great!

— Reply to this email directly or view it on GitHub https://github.com/robertotru/ToInlineStyleEmailBundle/pull/11#issuecomment-68794986 .