gushphp / ToInlineStyleEmailBundle

A Symfony2 bundle to use the CssToInlineStyles converter by Tijs Verkoyen
MIT License
59 stars 34 forks source link

Adds support for variable path on twig tag inlinecss #36

Closed cordoval closed 7 years ago

cordoval commented 7 years ago

Addresses https://github.com/gushphp/ToInlineStyleEmailBundle/issues/26

cordoval commented 7 years ago

@kalypso63 can you please send me your fix for the coding style as a PR to this PR? thanks 👍

also if you can squash this commits would be great, i tried to rebase it to be sure and it had several conflicts i couldn't continue.

kalypso63 commented 7 years ago

@cordoval the fix for coding style for README.md ? I m not available during 1 week. Can you do it without me ?

cordoval commented 7 years ago

@kalypso63 i will do it for you 👍

kalypso63 commented 7 years ago

Hi @cordoval. Could you progress on this point ?

cordoval commented 7 years ago

Yes i fell sick but i will come back to this On Monday, June 12, 2017, VANCLOOSTER Mickael notifications@github.com wrote:

Hi @cordoval https://github.com/cordoval. Could you advance on this point ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/robertotru/ToInlineStyleEmailBundle/pull/36#issuecomment-307834179, or mute the thread https://github.com/notifications/unsubscribe-auth/AAUCp_N3Nnl0YI4nGpWdn2cTbh1kzJ55ks5sDWAtgaJpZM4NuSI5 .

cordoval commented 7 years ago

@kalypso63 retaking this now

cordoval commented 7 years ago

going with my gut feeling 👍