search

gusmanb / logicanalyzer

24 channel, 100Msps logic analyzer hardware and software
GNU General Public License v3.0
1.71k stars 210 forks source link

Show basic error information when capture start fails #38

Closed aaronjamt closed 1 year ago

aaronjamt commented 1 year ago

Currently, the message is very vague and just says that there was an error. This isn't a ton better and it should probably be worked on more but it at least gives a better idea as to what the error actually is.

Additionally, the requirements for a successful capture should probably be shown in the README or somewhere more obvious. I had to dig through the source code to realize that the reason it wasn't capturing was because I set pre-samples to zero, thinking that I just wanted to maximize the number of samples after the trigger that it captured. I actually wound up reinstalling the firmware on the Pi Pico, redownloading the application from GitHub, rebooting both my machine and the Pi Pico several times, and was about to run a live linux distro until I saw that it was just because pre-samples has to be at least 2.

(Note: I haven't done any C# programming before and don't have a way to test this code. This is mostly an example of the general idea I have, although I don't know if it actually works.)

gusmanb commented 1 year ago

Hi.

Ok, the idea is ok but I'm going to close this PR, this patch breaks the CLI so it cannot be applied. Please open an issue with the request and when I go for the next release I will update the error messages, right now I am a bit "busy", I had a heart attack some weeks ago and I have the project on hold, when I continue with the development (I'm working on the W wireless version) I will add the new error messages.

Cheers.